You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "bibin sebastian (Jira)" <ji...@apache.org> on 2019/10/06 06:37:00 UTC

[jira] [Commented] (KAFKA-8977) Remove MockStreamsMetrics Since it is not a Mock

    [ https://issues.apache.org/jira/browse/KAFKA-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945258#comment-16945258 ] 

bibin sebastian commented on KAFKA-8977:
----------------------------------------

[~cadonna] shall I remove MockStreamsMetrics and instead use StreamsMetricsImpl in the testcases?
I dont see a real need to create a mock for StreamsMetricsImpl now.

> Remove MockStreamsMetrics Since it is not a Mock
> ------------------------------------------------
>
>                 Key: KAFKA-8977
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8977
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Bruno Cadonna
>            Assignee: bibin sebastian
>            Priority: Minor
>              Labels: newbie
>
> The class {{MockStreamsMetrics}} is used throughout unit tests as a mock but it is not really a mock since it only hides two parameters of the {{StreamsMetricsImpl}} constructor. Either a real mock or the real {{StreamsMetricsImpl}} should be used in the tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)