You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Mark Bretl <mb...@pivotal.io> on 2015/10/26 19:35:56 UTC
Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
-----------------------------------------------------------
Review request for geode, Kirk Lund and Dan Smith.
Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487
Repository: geode
Description
-------
This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.
Diffs
-----
build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
Diff: https://reviews.apache.org/r/39664/diff/
Testing
-------
Tested by running 'clean build'
Build now runs in about 5 minutes
Thanks,
Mark Bretl
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104065
-----------------------------------------------------------
What is the target for completely building and testing the product now?
- Dan Smith
On Oct. 26, 2015, 6:35 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 6:35 p.m.)
>
>
> Review request for geode, Kirk Lund and Dan Smith.
>
>
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
>
>
> Repository: geode
>
>
> Description
> -------
>
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
>
>
> Diffs
> -----
>
> build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
>
> Diff: https://reviews.apache.org/r/39664/diff/
>
>
> Testing
> -------
>
> Tested by running 'clean build'
>
> Build now runs in about 5 minutes
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104107
-----------------------------------------------------------
Ship it!
Might want to update the description for precheckin. Otherwise, looks good!
- Dan Smith
On Oct. 26, 2015, 11:04 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 11:04 p.m.)
>
>
> Review request for geode, Kirk Lund and Dan Smith.
>
>
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
>
>
> Repository: geode
>
>
> Description
> -------
>
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
>
>
> Diffs
> -----
>
> build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
>
> Diff: https://reviews.apache.org/r/39664/diff/
>
>
> Testing
> -------
>
> Tested by running 'clean build'
>
> Build now runs in about 5 minutes
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104108
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Oct. 26, 2015, 11:04 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 11:04 p.m.)
>
>
> Review request for geode, Kirk Lund and Dan Smith.
>
>
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
>
>
> Repository: geode
>
>
> Description
> -------
>
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
>
>
> Diffs
> -----
>
> build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
>
> Diff: https://reviews.apache.org/r/39664/diff/
>
>
> Testing
> -------
>
> Tested by running 'clean build'
>
> Build now runs in about 5 minutes
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Mark Bretl <mb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 11:04 p.m.)
Review request for geode, Kirk Lund and Dan Smith.
Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487
Repository: geode
Description
-------
This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.
Diffs (updated)
-----
build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
Diff: https://reviews.apache.org/r/39664/diff/
Testing
-------
Tested by running 'clean build'
Build now runs in about 5 minutes
Thanks,
Mark Bretl
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Mark Bretl <mb...@pivotal.io>.
> On Oct. 26, 2015, 9:58 p.m., Dan Smith wrote:
> > build.gradle, line 412
> > <https://reviews.apache.org/r/39664/diff/2/?file=1108490#file1108490line412>
> >
> > I'm not sure this covers everything the build task used to do. I think the build task also ran some other tasks like assemble, installDist, etc.
You can view the lifecycle by ./gradlew clean precheckin -Dskip.tests=true
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104093
-----------------------------------------------------------
On Oct. 26, 2015, 9:53 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 9:53 p.m.)
>
>
> Review request for geode, Kirk Lund and Dan Smith.
>
>
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
>
>
> Repository: geode
>
>
> Description
> -------
>
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
>
>
> Diffs
> -----
>
> build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
>
> Diff: https://reviews.apache.org/r/39664/diff/
>
>
> Testing
> -------
>
> Tested by running 'clean build'
>
> Build now runs in about 5 minutes
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104093
-----------------------------------------------------------
build.gradle (line 412)
<https://reviews.apache.org/r/39664/#comment162314>
I'm not sure this covers everything the build task used to do. I think the build task also ran some other tasks like assemble, installDist, etc.
- Dan Smith
On Oct. 26, 2015, 9:53 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 9:53 p.m.)
>
>
> Review request for geode, Kirk Lund and Dan Smith.
>
>
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
>
>
> Repository: geode
>
>
> Description
> -------
>
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
>
>
> Diffs
> -----
>
> build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
>
> Diff: https://reviews.apache.org/r/39664/diff/
>
>
> Testing
> -------
>
> Tested by running 'clean build'
>
> Build now runs in about 5 minutes
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39664: GEODE-487: Remove integrationTest and
distributedTest from build task.
Posted by Mark Bretl <mb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 9:53 p.m.)
Review request for geode, Kirk Lund and Dan Smith.
Changes
-------
Add precheckin task for running all tests
Bugs: GEODE-487
https://issues.apache.org/jira/browse/GEODE-487
Repository: geode
Description
-------
This commit removes integrationTest and distributedTest tasks from the
build task lifecycle. The tasks were associated with the 'check' task,
which is in the 'build' lifecycle. After removing the tasks, only the
'test' task is run when build task is executed.
Diffs (updated)
-----
build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db
Diff: https://reviews.apache.org/r/39664/diff/
Testing
-------
Tested by running 'clean build'
Build now runs in about 5 minutes
Thanks,
Mark Bretl