[GitHub] [bookkeeper] TakaHiR07 commented on pull request #3707: [improve] replace bookie from different rack of other quorum when do recovery

[GitBox <gi...@apache.org>]

TakaHiR07 commented on PR #3707:
URL: https://github.com/apache/bookkeeper/pull/3707#issuecomment-1358828549

   > For `RackAwarePolicy`, it will try its best effort to pick bookies from different racks. When doing recovery, it is safe to replace bookies from the same rack.
   
   In some extreme case, such as 5 bookies in 1 rack, 4 bookies down, 1 bookie survive. The recovery throughput would concentrate on this bookie. After recovery, it would result in data skew in this survived bookie. I think it is not really safe, maybe cause some problem.
   And when do recovery, it seems data locality is not exist. Because the recover bk client in ReplicationWorker is random distribution, it would read data from rack 2 and then recover data to rack 1. So it is not neccessary to ensure the replaced bookie in the same rack


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org