[GitHub] incubator-apex-core pull request: APEX-157 #comment #resolve Added...

[ilooner <gi...@git.apache.org>]

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/81#discussion_r40698828
  
    --- Diff: engine/src/test/resources/testTopology.json ---
    @@ -25,7 +25,7 @@
               "attributes": {
                 "UNIFIER_LIMIT": 8,
                 "STREAM_CODEC" : {
    -              "com.datatorrent.common.codec.JsonStreamCodec" : {}
    +              "com.datatorrent.stram.plan.logical.LogicalPlanConfigurationTest$TestStreamCodec" : {}
                 }
    --- End diff --
    
    I Tested with the original JSON and the testLoadFromJson test failed because the attribute is not serializable. As it is now this PR is backwards incompatible. Could we make the JsonStreamCodec serializable to make the original JSON work or does that introduce other issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---