You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/11 10:20:57 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8522:
[WIP][dashboard scoped filter] part 3: merge filter scope settings into
dashboard redux state
codecov-io edited a comment on issue #8522: [WIP][dashboard scoped filter] part 3: merge filter scope settings into dashboard redux state
URL: https://github.com/apache/incubator-superset/pull/8522#issuecomment-552382157
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=h1) Report
> Merging [#8522](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=desc) into [convert-ids-to-tabs-v2](https://codecov.io/gh/apache/incubator-superset/commit/03b722eae1fdec82ea9b2c5c2acefffdb7a6ad14?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `65.12%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## convert-ids-to-tabs-v2 #8522 +/- ##
=========================================================
- Coverage 66.82% 66.8% -0.02%
=========================================================
Files 468 471 +3
Lines 22893 22967 +74
Branches 2483 2487 +4
=========================================================
+ Hits 15299 15344 +45
- Misses 7433 7461 +28
- Partials 161 162 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et/assets/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlci5qc3g=) | `24% <ø> (ø)` | :arrow_up: |
| [...s/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlckNvbnRyb2xzLmpzeA==) | `11.62% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `47.74% <ø> (+4.5%)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `43.9% <ø> (ø)` | :arrow_up: |
| [...sets/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9GaWx0ZXJJbmRpY2F0b3JzLmpzeA==) | `77.77% <ø> (-4.05%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `69.56% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmQuanN4) | `0% <ø> (ø)` | :arrow_up: |
| [...shboard/util/charts/getFormDataWithExtraFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9jaGFydHMvZ2V0Rm9ybURhdGFXaXRoRXh0cmFGaWx0ZXJzLmpz) | `89.47% <ø> (-1.44%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9maWx0ZXJzY29wZS9GaWx0ZXJTY29wZVNlbGVjdG9yLmpzeA==) | `1.48% <0%> (-0.06%)` | :arrow_down: |
| [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/8522/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=footer). Last update [03b722e...aa679e8](https://codecov.io/gh/apache/incubator-superset/pull/8522?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org