[GitHub] [pinot] walterddr commented on a diff in pull request #11103: Improve error message in QueryDispatcher

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #11103:
URL: https://github.com/apache/pinot/pull/11103#discussion_r1263775378


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -101,6 +101,8 @@ public ResultTable submitAndReduce(long requestId, DispatchableSubPlan dispatcha
     } catch (Exception e) {
       cancel(requestId, dispatchableSubPlan);
       throw new RuntimeException("Error executing query: " + ExplainPlanPlanVisitor.explain(dispatchableSubPlan), e);
+    } catch (Throwable t) {

Review Comment:
   1. when a Throwable is caught, it usually indicates series issues and cannot be recovered. 
   2. netty handles the throwable thus the server didn't crash.
   
   so here is my .02
   1. don't need to explain the query, the throwable is serious enough that probably has nothing to do with the query itself.
   2. log it and re-throw the throwable makes more sense to me instead of wrapping it back into a RTE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org