[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #7889: [test] fix postgres test failure caused by empty slice.name

[GitBox <gi...@apache.org>]

graceguo-supercat opened a new pull request #7889: [test] fix postgres test failure caused by empty slice.name
URL: https://github.com/apache/incubator-superset/pull/7889
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   A postgres test always failed in my new PR. See a sample link here: https://travis-ci.org/apache/incubator-superset/jobs/560192028
   
   I found there is a logic to sort slices by name:
   `expected_dash.slices, key=lambda s: s.slice_name or ""`
   when multiple slices.name is empty, the order of expected_dash.slices becomes inconsistent. That cause the following test that compares each slice attribute, like viz_type, failed.
   
   ### TEST PLAN
   ci
   
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org