You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/26 15:55:08 UTC
[GitHub] merlimat opened a new pull request #2661: Fixed flaky test
BatchMessageTest.testBatchAndNonBatchCumulativeAcks
merlimat opened a new pull request #2661: Fixed flaky test BatchMessageTest.testBatchAndNonBatchCumulativeAcks
URL: https://github.com/apache/pulsar/pull/2661
### Motivation
Fixed flaky test :
```
Skip Message
expected [0] but found [4]
Standard Output
Created annotation listener
13:24:36.970 [main:org.apache.pulsar.broker.PulsarService@319] INFO org.apache.pulsar.broker.PulsarService - Starting Pulsar Broker service; version: '2.2.0.0-SNAPSHOT'
13:24:36.982 [main:org.apache.pulsar.broker.PulsarService@320] INFO org.apache.pulsar.broker.PulsarService - Git Revision b4b348da6dade88fbf08bc8f49e28f280455d985
13:24:36.984 [main:org.apache.pulsar.broker.PulsarService@321] INFO org.apache.pulsar.broker.PulsarService - Built by <> on asf902.gq1.y
...[truncated 42534 chars]...
position3:28:-1:4 data [B@6507f56b
13:24:43.543 [TestNG-method=testBatchAndNonBatchCumulativeAcks-1:org.apache.pulsar.broker.service.BatchMessageTest@563] INFO org.apache.pulsar.broker.service.BatchMessageTest - [bnb-sub-1] got message position3:29:-1 data [B@4ebac723
13:24:43.543 [TestNG-method=testBatchAndNonBatchCumulativeAcks-1:org.apache.pulsar.broker.service.BatchMessageTest@569] INFO org.apache.pulsar.broker.service.BatchMessageTest - [bnb-sub-1] did cumulative ack on position3:29:-1
```
Core issue is that the acks are by default grouped with 100ms delay. The `Thread.sleep(100)` was not enough to cover for that.
### Modifications
Removed ack grouping for this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services