You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/25 08:34:34 UTC
[GitHub] [apisix-dashboard] wmdmomo opened a new pull request #2002: feat(plugin): fix UI basic-auth
wmdmomo opened a new pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
The PR will change the plugin under plugin/UI (basic-auth), allowing basic-auth to dynamically adapt to the back-end json rules.
**Related issues**
fix/resolve #1588
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: e526b19e731227a2d6fb355ef3aa9261bdb51f16
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6124d5746d56df000878c535](https://app.netlify.com/sites/apisix-dashboard/deploys/6124d5746d56df000878c535?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2002--apisix-dashboard.netlify.app/](https://deploy-preview-2002--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 68ff37302146c7ab9d679594089c293800415acc
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6124d357db69ca00078dff98](https://app.netlify.com/sites/apisix-dashboard/deploys/6124d357db69ca00078dff98?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2002--apisix-dashboard.netlify.app/](https://deploy-preview-2002--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on a change in pull request #2002: feat(plugin): fix UI basic-auth
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r676134759
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
Because for the plug-in basic-auth, its back-end jsonschema is not specifically used, so here is just passing parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: f2418fc60f370bd55fccbff2c9859c48b6852ce2
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f67e346dcb8000705b441](https://app.netlify.com/sites/apisix-dashboard/deploys/611f67e346dcb8000705b441?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r693344371
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
nice, and then @wmdmomo can try to dynamically adapt to the required props. which the only rule for `basic-auth` plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r684776610
##########
File path: web/src/components/Plugin/UI/plugin.tsx
##########
@@ -55,7 +62,11 @@ export const PluginForm: React.FC<Props> = ({ name, schema, renderForm, form })
case 'api-breaker':
return <ApiBreaker form={form} />;
case 'basic-auth':
+<<<<<<< HEAD
Review comment:
I have removed those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2002: feat(plugin): fix UI basic-auth
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r676110336
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
Hi, @wmdmomo I couldn't find out where this field is used, could you please have a better description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r692769834
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
@liuxiran Thank you for your reminder. I have modified it. When the plugin is basic-auth, pass it as the value of consumer_schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886296868
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2002](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8fc14) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5a581d3f0fa0f74a634af93f14fc779c16454938?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a581d3) will **increase** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2002 +/- ##
==========================================
+ Coverage 65.69% 65.76% +0.06%
==========================================
Files 121 121
Lines 3204 3204
Branches 778 778
==========================================
+ Hits 2105 2107 +2
+ Misses 1099 1097 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `65.76% <0.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | `66.66% <ΓΈ> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <0.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a581d3...6d8fc14](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r684775539
##########
File path: web/src/components/Plugin/UI/plugin.tsx
##########
@@ -55,7 +62,11 @@ export const PluginForm: React.FC<Props> = ({ name, schema, renderForm, form })
case 'api-breaker':
return <ApiBreaker form={form} />;
case 'basic-auth':
+<<<<<<< HEAD
Review comment:
Please remove those lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: e526b19e731227a2d6fb355ef3aa9261bdb51f16
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6124d5746d56df000878c535](https://app.netlify.com/sites/apisix-dashboard/deploys/6124d5746d56df000878c535?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r694750951
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
@liuxiran Sorry for taking so long to reply. I have now verified the required items of the basic-auth plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 68ff37302146c7ab9d679594089c293800415acc
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6124d357db69ca00078dff98](https://app.netlify.com/sites/apisix-dashboard/deploys/6124d357db69ca00078dff98?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886296868
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2002](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1eddcb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5a581d3f0fa0f74a634af93f14fc779c16454938?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a581d3) will **increase** coverage by `0.49%`.
> The diff coverage is `97.14%`.
> :exclamation: Current head e1eddcb differs from pull request most recent head f2418fc. Consider uploading reports for the commit f2418fc to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2002 +/- ##
==========================================
+ Coverage 65.69% 66.19% +0.49%
==========================================
Files 121 121
Lines 3204 3227 +23
Branches 778 788 +10
==========================================
+ Hits 2105 2136 +31
+ Misses 1099 1091 -8
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `66.19% <97.14%> (+0.49%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | `66.66% <ΓΈ> (ΓΈ)` | |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <ΓΈ> (+4.91%)` | :arrow_up: |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <50.00%> (ΓΈ)` | |
| [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `66.25% <100.00%> (+0.20%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <100.00%> (+6.60%)` | :arrow_up: |
| [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `74.46% <100.00%> (+1.74%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a581d3...f2418fc](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 6d8fc14390524727cd30b1d56ee7cb7838e48c74
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fd510d910750008ec9199](https://app.netlify.com/sites/apisix-dashboard/deploys/610fd510d910750008ec9199?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-894583352
hi @wmdmomo please fix conflict files when you have time, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 6d8fc14390524727cd30b1d56ee7cb7838e48c74
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fd510d910750008ec9199](https://app.netlify.com/sites/apisix-dashboard/deploys/610fd510d910750008ec9199?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2002--apisix-dashboard.netlify.app/](https://deploy-preview-2002--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): fix UI basic-auth
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: b3e58fc3c3359a2bc25deddd8e40c814bfa8cf74
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd220d2c30dc00076e02cf](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd220d2c30dc00076e02cf?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2002--apisix-dashboard.netlify.app/](https://deploy-preview-2002--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#discussion_r692600400
##########
File path: web/src/components/Plugin/UI/basic-auth.tsx
##########
@@ -20,6 +20,7 @@ import { Form, Input } from 'antd';
type Props = {
form: FormInstance;
+ schema: Record<string, any> | undefined;
Review comment:
Hi @WillemJiang , sorry for taking so long to reply.
In fact there are two schema for `basic-auth` plugin, one is the `schema` as you pointed in the Screenshot, this is used for `Route` or `Service`. The other is the `consumer_schema`, this is for `Consumer`.
`basic-auth` form UI is used for `Consumer`, so please use the `consumer_schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 58bcd5bd8503ff217d268f9d62e6622a13a35026
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fd4b53c06790008d424af](https://app.netlify.com/sites/apisix-dashboard/deploys/610fd4b53c06790008d424af?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2002: feat(plugin): fix UI basic-auth
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886296868
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2002](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acbd1f9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0b5196f0b444dac8acb5cf60635806f024de6a0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b5196f) will **increase** coverage by `0.01%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head acbd1f9 differs from pull request most recent head b3e58fc. Consider uploading reports for the commit b3e58fc to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2002 +/- ##
==========================================
+ Coverage 64.01% 64.02% +0.01%
==========================================
Files 122 122
Lines 3154 3155 +1
Branches 753 753
==========================================
+ Hits 2019 2020 +1
Misses 1135 1135
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `64.02% <75.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | `66.66% <ΓΈ> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <50.00%> (ΓΈ)` | |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0b5196f...b3e58fc](https://codecov.io/gh/apache/apisix-dashboard/pull/2002?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: f2418fc60f370bd55fccbff2c9859c48b6852ce2
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f67e346dcb8000705b441](https://app.netlify.com/sites/apisix-dashboard/deploys/611f67e346dcb8000705b441?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2002--apisix-dashboard.netlify.app/](https://deploy-preview-2002--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo closed pull request #2002: feat(plugin): allowing basic-auth to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo closed pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2002: feat(plugin): fix UI basic-auth
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2002:
URL: https://github.com/apache/apisix-dashboard/pull/2002#issuecomment-886167235
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: b3e58fc3c3359a2bc25deddd8e40c814bfa8cf74
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd220d2c30dc00076e02cf](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd220d2c30dc00076e02cf?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org