You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/02 23:12:47 UTC
Review Request: Pulled 'stringify' out of utils,
added a stringify for lists and maps,
and updated all references appropriately.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5707/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/Makefile.am 8760f59
src/common/stringify.hpp PRE-CREATION
src/common/utils.hpp 93192e7
src/linux/proc.cpp 0ccd604
src/log/log.cpp 9189014
src/log/network.hpp 1237642
src/log/replica.cpp 8a3e4c5
src/master/http.cpp a4cc19d
src/master/master.cpp 89cdaf6
src/master/webui.cpp 39df4d9
src/slave/http.cpp 19c48a0
src/slave/slave.cpp aac11e0
src/slave/webui.cpp 0666efa
src/tests/log_tests.cpp c4720b9
src/tests/protobuf_io_tests.cpp 7c7db3e
src/tests/zookeeper_server.cpp 14c8f84
Diff: https://reviews.apache.org/r/5707/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Pulled 'stringify' out of utils,
added a stringify for lists and maps,
and updated all references appropriately.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 3, 2012, 4:18 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 192-198
> > <https://reviews.apache.org/r/5707/diff/1/?file=118922#file118922line192>
> >
> > trying to be alphabetically sorted but not?
It's a work in progress. ;)
> On July 3, 2012, 4:18 p.m., Vinod Kone wrote:
> > src/common/stringify.hpp, line 28
> > <https://reviews.apache.org/r/5707/diff/1/?file=118923#file118923line28>
> >
> > namespace?
Eventually stout, but none now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5707/#review8836
-----------------------------------------------------------
On July 2, 2012, 9:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5707/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 9:12 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 8760f59
> src/common/stringify.hpp PRE-CREATION
> src/common/utils.hpp 93192e7
> src/linux/proc.cpp 0ccd604
> src/log/log.cpp 9189014
> src/log/network.hpp 1237642
> src/log/replica.cpp 8a3e4c5
> src/master/http.cpp a4cc19d
> src/master/master.cpp 89cdaf6
> src/master/webui.cpp 39df4d9
> src/slave/http.cpp 19c48a0
> src/slave/slave.cpp aac11e0
> src/slave/webui.cpp 0666efa
> src/tests/log_tests.cpp c4720b9
> src/tests/protobuf_io_tests.cpp 7c7db3e
> src/tests/zookeeper_server.cpp 14c8f84
>
> Diff: https://reviews.apache.org/r/5707/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Pulled 'stringify' out of utils,
added a stringify for lists and maps,
and updated all references appropriately.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5707/#review8836
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/5707/#comment18773>
trying to be alphabetically sorted but not?
src/common/stringify.hpp
<https://reviews.apache.org/r/5707/#comment18774>
namespace?
- Vinod Kone
On July 2, 2012, 9:12 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5707/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 9:12 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 8760f59
> src/common/stringify.hpp PRE-CREATION
> src/common/utils.hpp 93192e7
> src/linux/proc.cpp 0ccd604
> src/log/log.cpp 9189014
> src/log/network.hpp 1237642
> src/log/replica.cpp 8a3e4c5
> src/master/http.cpp a4cc19d
> src/master/master.cpp 89cdaf6
> src/master/webui.cpp 39df4d9
> src/slave/http.cpp 19c48a0
> src/slave/slave.cpp aac11e0
> src/slave/webui.cpp 0666efa
> src/tests/log_tests.cpp c4720b9
> src/tests/protobuf_io_tests.cpp 7c7db3e
> src/tests/zookeeper_server.cpp 14c8f84
>
> Diff: https://reviews.apache.org/r/5707/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>