You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by David Jencks <da...@yahoo.com> on 2005/10/28 07:50:11 UTC
Combine common code in jetty and tomcat module builders?
I think there's a lot of code copied from the jetty to the tomcat
module builder. Now that both are somewhere near the verge of
stability, I'd like to refactor the common parts into a common
superclass. Any objections?
thanks
david jencks
Re: Combine common code in jetty and tomcat module builders?
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
Sounds great to me
Aaron
On 10/28/05, Jeff Genender <jg...@apache.org> wrote:
> +1...this is very good.
>
> Jeff
>
> David Jencks wrote:
> > I think there's a lot of code copied from the jetty to the tomcat module
> > builder. Now that both are somewhere near the verge of stability, I'd
> > like to refactor the common parts into a common superclass. Any
> > objections?
> >
> > thanks
> > david jencks
>
> --
> Jeff Genender
> http://geronimo.apache.org
>
>
Re: Combine common code in jetty and tomcat module builders?
Posted by Matt Hogstrom <ma...@hogstrom.org>.
+1 This is great
anita kulshreshtha wrote:
> Good idea. As discussed with Jeff offline I have
> been working on G-1035. I have made changes to the
> existing TomcatModuleBuilder to make it almost
> identical to JettyModuleBuilder except for the very
> small container specific part. Please let me know if
> you would like me to submit this at this stage.
>
> Thanks
> Anita
>
> --- Jeff Genender <jg...@apache.org> wrote:
>
>
>>+1...this is very good.
>>
>>Jeff
>>
>>David Jencks wrote:
>>
>>>I think there's a lot of code copied from the
>>
>>jetty to the tomcat module
>>
>>>builder. Now that both are somewhere near the
>>
>>verge of stability, I'd
>>
>>>like to refactor the common parts into a common
>>
>>superclass. Any
>>
>>>objections?
>>>
>>>thanks
>>>david jencks
>>
>>--
>>Jeff Genender
>>http://geronimo.apache.org
>>
>>
>
>
>
>
>
> __________________________________
> Yahoo! FareChase: Search multiple travel sites in one click.
> http://farechase.yahoo.com
>
>
>
Re: Combine common code in jetty and tomcat module builders?
Posted by anita kulshreshtha <a_...@yahoo.com>.
I do not have a working version :-(. I am still
making changes to 'tomcat' module to avoid using
tomcat's deployer. I will need time to finish this.
But after this the refactoring should be very easy.
Yes! I will do the refactoring after everything starts
working.
Thanks
Anita
--- David Jencks <da...@yahoo.com> wrote:
> If you have a working version, please submit it!
> This is great news!
> I think I should wait on combining them until your
> code is in. If you
> want to do the refactoring that would also be great!
>
> thanks
> david jencks
>
> On Oct 28, 2005, at 6:11 AM, anita kulshreshtha
> wrote:
>
> > Good idea. As discussed with Jeff offline I have
> > been working on G-1035. I have made changes to the
> > existing TomcatModuleBuilder to make it almost
> > identical to JettyModuleBuilder except for the
> very
> > small container specific part. Please let me know
> if
> > you would like me to submit this at this stage.
> >
> > Thanks
> > Anita
> >
> > --- Jeff Genender <jg...@apache.org> wrote:
> >
> >> +1...this is very good.
> >>
> >> Jeff
> >>
> >> David Jencks wrote:
> >>> I think there's a lot of code copied from the
> >> jetty to the tomcat module
> >>> builder. Now that both are somewhere near the
> >> verge of stability, I'd
> >>> like to refactor the common parts into a common
> >> superclass. Any
> >>> objections?
> >>>
> >>> thanks
> >>> david jencks
> >>
> >> --
> >> Jeff Genender
> >> http://geronimo.apache.org
> >>
> >>
> >
> >
> >
> >
> > __________________________________
> > Yahoo! FareChase: Search multiple travel sites in
> one click.
> > http://farechase.yahoo.com
> >
>
>
__________________________________
Yahoo! Mail - PC Magazine Editors' Choice 2005
http://mail.yahoo.com
Re: Combine common code in jetty and tomcat module builders?
Posted by David Jencks <da...@yahoo.com>.
If you have a working version, please submit it! This is great news!
I think I should wait on combining them until your code is in. If you
want to do the refactoring that would also be great!
thanks
david jencks
On Oct 28, 2005, at 6:11 AM, anita kulshreshtha wrote:
> Good idea. As discussed with Jeff offline I have
> been working on G-1035. I have made changes to the
> existing TomcatModuleBuilder to make it almost
> identical to JettyModuleBuilder except for the very
> small container specific part. Please let me know if
> you would like me to submit this at this stage.
>
> Thanks
> Anita
>
> --- Jeff Genender <jg...@apache.org> wrote:
>
>> +1...this is very good.
>>
>> Jeff
>>
>> David Jencks wrote:
>>> I think there's a lot of code copied from the
>> jetty to the tomcat module
>>> builder. Now that both are somewhere near the
>> verge of stability, I'd
>>> like to refactor the common parts into a common
>> superclass. Any
>>> objections?
>>>
>>> thanks
>>> david jencks
>>
>> --
>> Jeff Genender
>> http://geronimo.apache.org
>>
>>
>
>
>
>
> __________________________________
> Yahoo! FareChase: Search multiple travel sites in one click.
> http://farechase.yahoo.com
>
Re: Combine common code in jetty and tomcat module builders?
Posted by anita kulshreshtha <a_...@yahoo.com>.
Good idea. As discussed with Jeff offline I have
been working on G-1035. I have made changes to the
existing TomcatModuleBuilder to make it almost
identical to JettyModuleBuilder except for the very
small container specific part. Please let me know if
you would like me to submit this at this stage.
Thanks
Anita
--- Jeff Genender <jg...@apache.org> wrote:
> +1...this is very good.
>
> Jeff
>
> David Jencks wrote:
> > I think there's a lot of code copied from the
> jetty to the tomcat module
> > builder. Now that both are somewhere near the
> verge of stability, I'd
> > like to refactor the common parts into a common
> superclass. Any
> > objections?
> >
> > thanks
> > david jencks
>
> --
> Jeff Genender
> http://geronimo.apache.org
>
>
__________________________________
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com
Re: Combine common code in jetty and tomcat module builders?
Posted by Jeff Genender <jg...@apache.org>.
+1...this is very good.
Jeff
David Jencks wrote:
> I think there's a lot of code copied from the jetty to the tomcat module
> builder. Now that both are somewhere near the verge of stability, I'd
> like to refactor the common parts into a common superclass. Any
> objections?
>
> thanks
> david jencks
--
Jeff Genender
http://geronimo.apache.org