[GitHub] [maven-war-plugin] scottkurz opened a new pull request #19: [MWAR-441] - Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)

[GitBox <gi...@apache.org>]

scottkurz opened a new pull request #19:
URL: https://github.com/apache/maven-war-plugin/pull/19


   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [X ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWAR) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Format the pull request title like `[MWAR-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MWAR-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-war-plugin] hboutemy closed pull request #19: [MWAR-441] - Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)

[GitBox <gi...@apache.org>]

hboutemy closed pull request #19:
URL: https://github.com/apache/maven-war-plugin/pull/19


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-war-plugin] hboutemy commented on pull request #19: [MWAR-441] - Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)

[GitBox <gi...@apache.org>]

hboutemy commented on pull request #19:
URL: https://github.com/apache/maven-war-plugin/pull/19#issuecomment-835822983


   merged in https://github.com/apache/maven-war-plugin/commit/17e71f8569c7c236ba7f918095942e3e26861c55
   thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-war-plugin] scottkurz commented on pull request #19: [MWAR-441] - Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)

[GitBox <gi...@apache.org>]

scottkurz commented on pull request #19:
URL: https://github.com/apache/maven-war-plugin/pull/19#issuecomment-835829453


   Thx @hboutemy  .. one quick note:
   
   Wasn't sure how to write up the doc not knowing the next version: 3.3.2, 3.4.0, etc.
   
   [Here](https://github.com/apache/maven-war-plugin/blob/17e71f8569c7c236ba7f918095942e3e26861c55/src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java#L368) I wrote: 
   
   ```
      * Starting with <b>3.3.2</b>, if a value of "/" is specified the entire
      * webappDirectory will be checked, i.e. the "/" signifies "root".
   ```
   
   but the JIRA shows:
   
   **Fix Version/s:
   3.4.0**
   
   so perhaps this should be updated at some point?  
   
   Not sure how this is typically handled but if you want me to do a PR as the release gets closer I could.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org