[GitHub] markusthoemmes commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker
URL: https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r191887198
 
 

 ##########
 File path: ansible/roles/controller/tasks/deploy.yml
 ##########
 @@ -236,6 +236,11 @@
 
       "CONFIG_whisk_transactions_header": "{{ transactions.header }}"
 
+- name: merge extra env variables
+  set_fact:
+    controller_env: "{{ controller_env | default({}) | combine(controller.extraEnv) }}"
+  when: controller.extraEnv | default(false)
 
 Review comment:
   Why is the `when` needed in the first place? Shouldn't we be able to specify: `extraEnv: "{{ controller_extraEnv | default({}) }}"` and run the combine step no matter what?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services