[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5617: Add segment encryption on Controller based on table config

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #5617:
URL: https://github.com/apache/incubator-pinot/pull/5617#issuecomment-653168392


   > > I would recommend putting this under the `SegmentsValidationAndRetentionConfig` instead of creating another top level config.
   > 
   > Why is this the right place for this config. IMO, SegmentsValidationAndRetentionConfig should be broken into multiple sections.
   
   That's why I added a TODO in this config: `TODO: Consider break this config into multiple configs`
   At least we can rename it to `SegmentsConfig`.
   But I don't think this is in the scope of this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org