You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 09:28:31 UTC
[GitHub] [apisix-dashboard] starsz opened a new issue #1161: Feat: remove the etcd dependency in the unit test
starsz opened a new issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161
# Feature request
## Please describe your feature
Now, `route`, `ssl` `services` and `upstream` module are use etcd to store info.
I think we should remove the etcd dependency in the unit test.
## Describe the solution you'd like
Use store.MockInterface{} instead of using the etcd.
- [ ] route
- [ ] ssl
- [ ] services
- [ ] upstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-771449425
finish test cases of route, service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-771449425
finish test cases of route, service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz closed issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen edited a comment on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-771449425
finish test cases of route, service in M2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-796628057
This problem was solved. Thank you for every contributor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-773911342
@starsz
Hi,I have finished writing the SSL unit test, and if you do not start writing the upstream unit test, I can do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550
This is a big project, I will finish part of them in M2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-773931439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-753723858
> If we need to resolve this issue in 2.3 or 2.4?
I think it's a feature. So we may resolve it in 2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550
This is a big project, I will finish part of them in M2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz edited a comment on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-773932122
Because the test cases of the route, service had finished, so I think we can change the milestone to M2.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen edited a comment on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-771449425
finish test cases of route, service in M2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-752652994
Agree +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-773911342
@starsz
Hi,I have finished writing the SSL unit test, and if you do not start writing the upstream unit test, I can do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1161: Feat: remove the etcd dependency in the unit test
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1161:
URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-753714565
If we need to resolve this issue in 2.3 or 2.4?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org