You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "maxburke (via GitHub)" <gi...@apache.org> on 2023/03/06 18:02:15 UTC
[GitHub] [arrow-datafusion] maxburke opened a new pull request, #5487: Pass booleans by value instead of by reference
maxburke opened a new pull request, #5487:
URL: https://github.com/apache/arrow-datafusion/pull/5487
Fixes #5486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5487: Pass booleans by value instead of by reference
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5487:
URL: https://github.com/apache/arrow-datafusion/pull/5487#issuecomment-1460803032
Thanks @maxburke and @waynexia !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5487: Pass booleans by value instead of by reference
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5487:
URL: https://github.com/apache/arrow-datafusion/pull/5487#issuecomment-1458876813
Looks like this PR has a few tests that need to be updated to get Ci to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5487: Pass booleans by value instead of by reference
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5487:
URL: https://github.com/apache/arrow-datafusion/pull/5487#issuecomment-1460805075
Benchmark runs are scheduled for baseline = deeaa5632ed99a58b91767261570756db736d158 and contender = 9e32de3440a76574d177f0783b9328d98adfd6e2. 9e32de3440a76574d177f0783b9328d98adfd6e2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/25620885154940368258353bc58ac3aa...1c8761e3fb554bb5ad187376a950200a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2c0c6234ea8d4665ba98c37c707a0b78...ddf74a3e5c9748eca77a6cda796a3d9c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a1176678060249e68c648052723225a9...9923e0700d784d62b21763301bf152fe/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bcaf4c2f736f4561abcd038589dc8609...01a12a8272ff43959efee57cb28e07bd/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5487: Pass booleans by value instead of by reference
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5487:
URL: https://github.com/apache/arrow-datafusion/pull/5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org