You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/12/19 17:23:07 UTC
[GitHub] flink pull request #5183: [FLINK-8295][cassandra][build] properly shade nett...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5183
[FLINK-8295][cassandra][build] properly shade netty for the datastax driver
## What is the purpose of the change
`com.datastax.driver.core.NettyUtil` expects netty to be present either at its original package (`io.netty`) or relocated to `com.datastax.shaded.netty`. By relocating it to this package we make sure the driver follows its designated path and is able to connect at all.
## Brief change log
- relocate netty to `com.datastax.shaded.netty` instead of our own namespace
## Verifying this change
This change added tests and can be verified as follows:
- verified the build jar contains netty (only) in `com.datastax.shaded.netty` and not under `org.apache.flink.cassandra.shaded.io.netty`
- run a job that uses cassandra (should not have worked without adding netty before and should work now - haven't tested it yet - @twalthr can you jump in here?)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-8295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5183
----
commit 80c00a28dbf01ab4f31220c2005d7eeee8a76316
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-12-19T17:14:19Z
[FLINK-8295][cassandra][build] properly shade netty for the datastax driver
com.datastax.driver.core.NettyUtil expects netty to be present either at its
original package or relocated to com.datastax.shaded.netty. By relocating it
to this package we make sure the driver follows its designated path.
----
---
[GitHub] flink pull request #5183: [FLINK-8295][cassandra][build] properly shade nett...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5183
---
[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...
Posted by mcfongtw <gi...@git.apache.org>.
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/5183
+1 for this change, @NicoK . I did not see this error as I was working on FLINK-6805 - my bad :(. Also, you might want to remove those comment to avoid future confusion.
---
[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5183
I tested it locally. Will merge this now...
---
[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/5183
true - I adapted the comment accordingly
---
[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5183
Thanks for the fix @NicoK. I will have a look at it later today and merge this.
---