You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 16:12:50 UTC
[GitHub] [airflow] ashb opened a new pull request #16596: Fix label_when_reviewed_workflow_run permissions
ashb opened a new pull request #16596:
URL: https://github.com/apache/airflow/pull/16596
This workflow run is currently failing with:
```
Run ./.github/actions/checks-action
with:
token: ***
name: Selective build check
status: in_progress
sha: 2cf8c7f268c1db73d840f029aa5180941519c492
details_url: https://github.com/apache/airflow/actions/runs/960898933
output: {"summary": "Checking selective status of the build in [the run](https://github.com/apache/airflow/actions/runs/960898933) "}
Error: Resource not accessible by integration
```
so I _think_ this will help
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16596:
URL: https://github.com/apache/airflow/pull/16596#discussion_r656379394
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -23,6 +23,7 @@ on: # yamllint disable-line rule:truthy
types: ['requested']
permissions:
# All other permissions are set to none
+ chekcs: write
Review comment:
is this a typo or it is how it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16596:
URL: https://github.com/apache/airflow/pull/16596#discussion_r656495598
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -23,6 +23,7 @@ on: # yamllint disable-line rule:truthy
types: ['requested']
permissions:
# All other permissions are set to none
+ chekcs: write
Review comment:
```suggestion
checks: write
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16596:
URL: https://github.com/apache/airflow/pull/16596#discussion_r656507403
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -23,6 +23,7 @@ on: # yamllint disable-line rule:truthy
types: ['requested']
permissions:
# All other permissions are set to none
+ chekcs: write
Review comment:
Whoops yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16596:
URL: https://github.com/apache/airflow/pull/16596#discussion_r656494523
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -23,6 +23,7 @@ on: # yamllint disable-line rule:truthy
types: ['requested']
permissions:
# All other permissions are set to none
+ chekcs: write
Review comment:
yeah. Typo I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16596:
URL: https://github.com/apache/airflow/pull/16596#issuecomment-866126239
@potiuk PTAL -- I think this is the missing permission, but the error doesn't really provide much/any clue.
Failing example https://github.com/apache/airflow/runs/2885563848?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16596: Fix label_when_reviewed_workflow_run permissions
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16596:
URL: https://github.com/apache/airflow/pull/16596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org