You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/25 03:32:48 UTC
[GitHub] [spark] sadhen opened a new pull request #32327: [SPARK-34771][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
sadhen opened a new pull request #32327:
URL: https://github.com/apache/spark/pull/32327
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826281678
**[Test build #137912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137912/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on a change in pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on a change in pull request #32327:
URL: https://github.com/apache/spark/pull/32327#discussion_r625957662
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
##########
@@ -96,37 +96,53 @@ object EvaluatePython {
case c: Short => c.toByte
case c: Int => c.toByte
case c: Long => c.toByte
+ case c: Float => c.toByte
+ case c: Double => c.toByte
}
case ShortType => (obj: Any) => nullSafeConvert(obj) {
case c: Byte => c.toShort
case c: Short => c
case c: Int => c.toShort
case c: Long => c.toShort
+ case c: Float => c.toShort
+ case c: Double => c.toShort
Review comment:
It seems odd that we would want to silently convert a double to a short. Are we sure that is the correct behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32327: [SPARK-35211][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826274708
@sadhen, SPARK-35211 is not merged yet, and it makes less sense to call it a followup. Let's make a separate JIRA for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826277245
**[Test build #137904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137904/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242974
**[Test build #137904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137904/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32327: [SPARK-34771][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242257
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32327: [SPARK-35211][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826275268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-831646835
Hmm, first I am confused by why there are many PRs for the same JIRA? Are they for the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826316946
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137912/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] darcy-shen commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
darcy-shen commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-886421206
> Are they for the same issue?
Yes. There are for the same issues but from different part of the code path.
Well, now I've created another JIRA ticket to track this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826316692
**[Test build #137912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137912/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826281678
**[Test build #137912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137912/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32327: [SPARK-34771][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32327: [SPARK-35211][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826274708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sadhen commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
sadhen commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826477653
> We should probably define one standard to follow.
I don't know about standard. That's why I only do conversion for numeric type: int/long/byte/short/float/double.
How about fix for numeric type first?
Could you describe the problem in detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] darcy-shen edited a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
darcy-shen edited a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-886421206
> Are they for the same issue?
Yes. They are for the same issues but from different part of the code path.
Well, now I've created another JIRA ticket (https://issues.apache.org/jira/browse/SPARK-36283) to track this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826316946
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137912/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242974
**[Test build #137904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137904/testReport)** for PR 32327 at commit [`829dda9`](https://github.com/apache/spark/commit/829dda9c76ad45e30e1a7758099a34159a1e9cdb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON][FOLLOW_UP] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826242257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sadhen commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
sadhen commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826477653
> We should probably define one standard to follow.
I don't know about standard. That's why I only do conversion for numeric type: int/long/byte/short/float/double.
How about fix for numeric type first?
Could you describe the problem in detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-831644826
cc @ueshin @BryanCutler @viirya too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826289676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42433/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-831644758
I am okay with this change but you'll have to update https://github.com/apache/spark/blob/master/python/pyspark/sql/functions.py#L4922-L4940 as well by using the codes here: https://github.com/apache/spark/commit/9b9d81b821b1333c9d5168d55b12f07e8d7645a4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826281275
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137904/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] darcy-shen closed pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
darcy-shen closed pull request #32327:
URL: https://github.com/apache/spark/pull/32327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] darcy-shen edited a comment on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
darcy-shen edited a comment on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-886421206
> Are they for the same issue?
Yes. There are for the same issues but from different part of the code path.
Well, now I've created another JIRA ticket (https://issues.apache.org/jira/browse/SPARK-36283) to track this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32327: [SPARK-35211][PYTHON] Proper NumericType conversion for applySchemaToPythonRDD
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32327:
URL: https://github.com/apache/spark/pull/32327#issuecomment-826287164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org