You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/06 10:34:19 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
EricGao888 opened a new pull request, #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332
## Purpose of the pull request
* Still WIP.
* Update jUnit to 5.+
* This PR closes: #10976
## Brief change log
* Still WIP.
## Verify this pull request
* Still WIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210097752
> SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
>
> [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2101 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
>
> [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [38.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density
&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
Please check the sonar result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1207194242
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1252414283
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1211014792
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210615860
> > BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
> >
> > 1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` [[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573](https://github.com/apache/dolphinscheduler/issues/10573).
> > 2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
> >
> > However, I think the second method is a bit risky.
> > WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun
>
> I prefer the second way.
I just tried migrating all the UTs and got blocked.
Specifically speaking, there are two risks:
1. We need to switch all the UTs to use jUnit 5 and `Spotless` will automatically reformat them. I've tried it, there would be 333 files modified.
2. We used `powermock` quite a lot in the project and `powermock` does not support `jUnit 5` as stated in https://github.com/apache/dolphinscheduler/issues/10976#issuecomment-1207427898. It is hardly possible to refactor all the code using `powermock` in one PR.
The real issue blocking me is the second one. May I ask whether there is a good way, or some kind of workaround for the second point? @ruanwenjun @kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1252402600
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1208348484
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2101 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [38.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214564059
I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in
https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project.
FYI, here is the mailing thread where they discussed above the migration: https://www.mail-archive.com/dev@flink.apache.org/msg47657.html
WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1211017508
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1208273264
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2101 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [38.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r941967360
##########
pom.xml:
##########
@@ -309,23 +309,57 @@
<artifactId>dolphinscheduler-tools</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit</groupId>
+ <artifactId>junit-bom</artifactId>
+ <version>5.9.0</version>
Review Comment:
Yes, I will add it to properties. Same as that of `mockito`
##########
pom.xml:
##########
@@ -309,23 +309,57 @@
<artifactId>dolphinscheduler-tools</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit</groupId>
+ <artifactId>junit-bom</artifactId>
+ <version>5.9.0</version>
Review Comment:
Yes, I will add it to properties. Same as that of `mockito`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r940361303
##########
dolphinscheduler-api/pom.xml:
##########
@@ -119,86 +130,80 @@
</exclusion>
</exclusions>
</dependency>
-
+
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger2</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-models</artifactId>
</dependency>
-
+
<dependency>
<groupId>com.github.xiaoymin</groupId>
<artifactId>swagger-bootstrap-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>org.hibernate.validator</groupId>
<artifactId>hibernate-validator</artifactId>
</dependency>
-
+
Review Comment:
Can you remove the indentations? And add this to spotless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1207193455
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11332](https://codecov.io/gh/apache/dolphinscheduler/pull/11332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2621ec4) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/bf5f7a88c5a7ef1c7772c6b9c5830fd72dc599ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf5f7a8) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #11332 +/- ##
============================================
- Coverage 40.26% 40.24% -0.02%
+ Complexity 4843 4842 -1
============================================
Files 974 974
Lines 37323 37323
Branches 4142 4142
============================================
- Hits 15028 15022 -6
- Misses 20749 20755 +6
Partials 1546 1546
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erver/master/processor/queue/TaskEventService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11332/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50U2VydmljZS5qYXZh) | `69.64% <0.00%> (-10.72%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1207194206
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1211054006
@ruanwenjun @kezhenxu94 @caishunfeng
Finally I managed to remove the dependency of `jUnit 4` since it is wired, ugly and confusing to have two versions of `jUnit` in `pom.xml`.
I have the same worries that ` if we still keep the Junit4, we need to constantly remind contributors to use Junit5`.
However, even though I have removed the dependency of `jUnit 4`, contributors still could write `jUnit 4` fashion UTs as long as we use `junit-vintage-engine`. It is quite difficult to migrate all legacy tests in this PR. I will keep working on this but I prefer doing it iteratively.
About `Powermock`, It seems we could use high version (greater than 3.4.0) `Mockito` to mock static methods and I've already added the dependency in this PR. I need more time to find out whether the latest `Mockito` could fully replace `Powermock` since we use `Powermock` quite a lot previously. Also, I find someone use `bytebuddy` to do some trick but I'm not sure whether this trick could apply here: https://git.stklcode.de/stklcode/juraclient/commit/c9444bbc971cd36f80824c3e7ec9baf8ecfbd676.
But I believe we could get rid of `Powermock` as long as we set our minds to : )
For the rest of the legacy tests, we could migrate some of them easily with `Intellij`, but still, there are some complicated ones we need to do it manually.
Above all, there are two action items after this PR, if you agree:
- [ ] Remove dependency of `Powermock`. https://github.com/apache/dolphinscheduler/issues/11405.
- [ ] Migrate legacy code and replace `junit-vintage-engine` with `junit-jupiter-engine`.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r941967469
##########
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java:
##########
@@ -42,15 +42,19 @@
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;
+import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
+//@RunWith(MockitoJUnitRunner.class)
Review Comment:
Sure, I will recover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1221897168
Good to hear we can remove powermock 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1221246447
Powermock is getting more and more annoying such as https://github.com/apache/dolphinscheduler/runs/7929368593?check_suite_focus=true
I'd rather just review and remove all those tests involving Powermock...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1208341931
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2101 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [38.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210696975
> > > BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
> > >
> > > 1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` [[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573](https://github.com/apache/dolphinscheduler/issues/10573).
> > > 2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
> > >
> > > However, I think the second method is a bit risky.
> > > WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun
> >
> >
> > I prefer the second way.
>
> I just tried migrating all the UTs and got blocked.
>
> Specifically speaking, there are two risks:
>
> 1. We need to switch all the UTs to use jUnit 5 and `Spotless` will automatically reformat them. I've tried it, there would be 333 files modified.
This is totally OK to me, "migrations" are always huge changes...
> 2. We used `powermock` quite a lot in the project and `powermock` does not support `jUnit 5` as stated in [[Improvement][UT] Upgrade junit to 5.+ #10976 (comment)](https://github.com/apache/dolphinscheduler/issues/10976#issuecomment-1207427898). It is hardly possible to refactor all the code using `powermock` in one PR.
>
> The real issue blocking me is the second one. May I ask whether there is a good way, or some kind of workaround for the second point? @ruanwenjun @kezhenxu94
I hope we could finally get rid of powermock one day, did you find any alternative to Powermock in JUnit5 platform? Or it's just impossible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r941964681
##########
pom.xml:
##########
@@ -309,23 +309,57 @@
<artifactId>dolphinscheduler-tools</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit</groupId>
+ <artifactId>junit-bom</artifactId>
+ <version>5.9.0</version>
Review Comment:
Is it better to set version in properties for unified version management?
##########
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java:
##########
@@ -42,15 +42,19 @@
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;
+import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
+//@RunWith(MockitoJUnitRunner.class)
Review Comment:
Should this comment be recover?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210427084
BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` #10573.
2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
However, I think the second method is a bit risky.
WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214702962
> > > I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project.
> > > FYI, here is the mailing thread where they discussed about the migration: https://www.mail-archive.com/dev@flink.apache.org/msg47657.html
> > > WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS
> >
> >
> > cc @zhongjiajie
>
> Maybe there are other historical reasons of flink,dolphischeduler do not have many unitest currently, IMO if we can migrate all of them to junit5 now it is the time
@zhongjiajie The workload to migrate all of them is quite large. Currently, because of those `powermock`, I could not give an exact estimate of the specific workload. If we decide to do so, first of all, we need to remove all the code related to powermock #11405 . Then, we need to get back to this PR to add dependency on jUnit5 and manually migrate the complex part which IDE could not do automatically e.g. change `expected = Exception.class` to `Assertions.assertThrows`. After these two done, we could try to use `Intellij` to migrate the rest and see how many of the rest will break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214569261
> I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project.
>
> FYI, here is the mailing thread where they discussed about the migration: https://www.mail-archive.com/dev@flink.apache.org/msg47657.html
>
> WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS
cc @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214691472
> > I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project.
> > FYI, here is the mailing thread where they discussed about the migration: https://www.mail-archive.com/dev@flink.apache.org/msg47657.html
> > WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS
>
> cc @zhongjiajie
Maybe there are other historical reasons of flink,dolphischeduler do not have many unitest currently, IMO if we can migrate all of them to junit5 now it is the time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214803159
> > I just worry if we still keep the Junit4, we need to constantly remind contributors to use Junit5.
>
> Agree, same concern to me
@ruanwenjun @ BTW, for the concern that contributors may write UTs with `jUnit 4`, we could add `regex` in `Spotless` check rules to prevent them from using `jUnit 4`. This will work in CI too. The same with `Powermock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1221893292
> Powermock is getting more and more annoying such as https://github.com/apache/dolphinscheduler/runs/7929368593?check_suite_focus=true
>
> [powermock/powermock#1112](https://github.com/powermock/powermock/issues/1112)
>
> I'd rather just review and remove all those tests involving Powermock...
@kezhenxu94 To follow up on this comment, I did some experiments on replacing `Powermock` with `Mockito` and it worked well, see #11588. I think it is possible to remove the dependency of `Powermock`.
For some more difficult cases such as:
1. Legacy code using some external APIs which are really hard to mock
2. Legacy code instantiating stuff with `new` keyword
We could:
1. Encapsulate the external APIs
2. Inject dependencies as below:
https://stackoverflow.com/questions/15052984/what-is-the-difference-between-mocking-and-spying-when-using-mockito#:~:text=about%20partial%20mocks.-,Mockito.,passed%20to%20spy()%20method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r940391848
##########
dolphinscheduler-api/pom.xml:
##########
@@ -119,86 +130,80 @@
</exclusion>
</exclusions>
</dependency>
-
+
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger2</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-models</artifactId>
</dependency>
-
+
<dependency>
<groupId>com.github.xiaoymin</groupId>
<artifactId>swagger-bootstrap-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>org.hibernate.validator</groupId>
<artifactId>hibernate-validator</artifactId>
</dependency>
-
+
Review Comment:
Nailed it, it was overwritten here: https://github.com/apache/dolphinscheduler/blob/983f9b41bf86bb07a3b439eadf4e7bc201d4def7/pom.xml#L657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1208271974
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11332)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL) [2101 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11332&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list) [38.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11332&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#discussion_r940372263
##########
dolphinscheduler-api/pom.xml:
##########
@@ -119,86 +130,80 @@
</exclusion>
</exclusions>
</dependency>
-
+
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger2</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.springfox</groupId>
<artifactId>springfox-swagger-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-models</artifactId>
</dependency>
-
+
<dependency>
<groupId>com.github.xiaoymin</groupId>
<artifactId>swagger-bootstrap-ui</artifactId>
</dependency>
-
+
<dependency>
<groupId>org.hibernate.validator</groupId>
<artifactId>hibernate-validator</artifactId>
</dependency>
-
+
Review Comment:
Sure, a bit wired though,
was `indent_empty_lines` not working? https://github.com/apache/dolphinscheduler/blob/983f9b41bf86bb07a3b439eadf4e7bc201d4def7/style/spotless_dolphinscheduler_formatter.xml#L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210550244
> BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
>
> 1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` [[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573](https://github.com/apache/dolphinscheduler/issues/10573).
> 2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
>
> However, I think the second method is a bit risky.
>
> WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun
I prefer the second way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210690585
> > > BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
> > >
> > > 1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` [[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573](https://github.com/apache/dolphinscheduler/issues/10573).
> > > 2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
> > >
> > > However, I think the second method is a bit risky.
> > > WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun
> >
> >
> > I prefer the second way.
>
> I just tried migrating all the UTs and got blocked.
>
> Specifically speaking, there are two risks:
>
> 1. We need to switch all the UTs to use jUnit 5 and `Spotless` will automatically reformat them. I've tried it, there would be 333 files modified.
> 2. We used `powermock` quite a lot in the project and `powermock` does not support `jUnit 5` as stated in [[Improvement][UT] Upgrade junit to 5.+ #10976 (comment)](https://github.com/apache/dolphinscheduler/issues/10976#issuecomment-1207427898). It is hardly possible to refactor all the code using `powermock` in one PR.
>
> The real issue blocking me is the second one. May I ask whether there is a good way, or some kind of workaround for the second point? @ruanwenjun @kezhenxu94
I just worry if we still keep the Junit4, we need to constantly remind contributors to use Junit5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210697294
> I just worry if we still keep the Junit4, we need to constantly remind contributors to use Junit5.
Agree, same concern to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1211571913
FYI here is a list of UT files which uses `Powermock`:
```txt
Found Occurrences in Directory dolphinscheduler with mask '*.java' (192 usages found)
Unclassified (192 usages found)
dolphinscheduler-alert-server (1 usage found)
org.apache.dolphinscheduler.alert (1 usage found)
AlertServerTest.java (1 usage found)
dolphinscheduler-api (27 usages found)
org.apache.dolphinscheduler.api.controller (5 usages found)
DataAnalysisControllerTest.java (1 usage found)
ProcessInstanceControllerTest.java (1 usage found)
ProcessTaskRelationControllerTest.java (1 usage found)
ResourcesControllerTest.java (1 usage found)
WorkerGroupControllerTest.java (1 usage found)
org.apache.dolphinscheduler.api.interceptor (2 usages found)
RateLimitInterceptorTest.java (2 usages found)
org.apache.dolphinscheduler.api.service (20 usages found)
BaseServiceTest.java (3 usages found)
DataAnalysisServiceTest.java (2 usages found)
DataSourceServiceTest.java (4 usages found)
LoggerServiceTest.java (1 usage found)
ResourcesServiceTest.java (4 usages found)
SchedulerServiceTest.java (2 usages found)
TenantServiceTest.java (1 usage found)
UdfFuncServiceTest.java (3 usages found)
dolphinscheduler-common (10 usages found)
org.apache.dolphinscheduler.common.utils (10 usages found)
CommonUtilsTest.java (2 usages found)
FileUtilsTest.java (3 usages found)
HadoopUtilsTest.java (4 usages found)
NetUtilsTest.java (1 usage found)
dolphinscheduler-datasource-api (9 usages found)
org.apache.dolphinscheduler.plugin.datasource.api.client (4 usages found)
CommonDataSourceClientTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.api.utils (5 usages found)
CommonUtilsTest.java (5 usages found)
dolphinscheduler-datasource-clickhouse (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.clickhouse (4 usages found)
ClickHouseDataSourceChannelTest.java (4 usages found)
dolphinscheduler-datasource-db2 (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.db2 (4 usages found)
DB2DataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.db2.param (3 usages found)
Db2DataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-hive (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.hive (4 usages found)
HiveDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.hive.param (3 usages found)
HiveDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-mysql (14 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql (4 usages found)
MySQLDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.param (3 usages found)
MySQLDataSourceProcessorTest.java (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.provider (3 usages found)
JDBCDataSourceProviderTest.java (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.mysql.utils (4 usages found)
DataSourceUtilsTest.java (4 usages found)
dolphinscheduler-datasource-oracle (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.oracle (4 usages found)
OracleDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.oracle.param (3 usages found)
OracleDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-postgresql (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.postgresql (4 usages found)
PostgreSQLDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.postgresql.param (3 usages found)
PostgreSQLDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-presto (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.presto (4 usages found)
PrestoDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.presto.param (3 usages found)
PrestoDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-redshift (3 usages found)
org.apache.dolphinscheduler.plugin.datasource.redshift.param (3 usages found)
RedshiftDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-spark (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.spark (4 usages found)
SparkDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.spark.param (3 usages found)
SparkDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-datasource-sqlserver (7 usages found)
org.apache.dolphinscheduler.plugin.datasource.sqlserver (4 usages found)
SQLServerDataSourceChannelTest.java (4 usages found)
org.apache.dolphinscheduler.plugin.datasource.sqlserver.param (3 usages found)
SQLServerDataSourceProcessorTest.java (3 usages found)
dolphinscheduler-log-server (3 usages found)
org.apache.dolphinscheduler.server.log (3 usages found)
LoggerRequestProcessorTest.java (3 usages found)
dolphinscheduler-master (18 usages found)
org.apache.dolphinscheduler.server.master (3 usages found)
SubProcessTaskTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.processor (5 usages found)
CacheProcessorTest.java (1 usage found)
TaskAckProcessorTest.java (3 usages found)
TaskKillResponseProcessorTest.java (1 usage found)
org.apache.dolphinscheduler.server.master.registry (3 usages found)
MasterRegistryClientTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.runner (4 usages found)
MasterTaskExecThreadTest.java (1 usage found)
WorkflowExecuteRunnableTest.java (3 usages found)
org.apache.dolphinscheduler.server.master.service (3 usages found)
FailoverServiceTest.java (3 usages found)
dolphinscheduler-server (4 usages found)
org.apache.dolphinscheduler.server.utils (4 usages found)
ProcessUtilsTest.java (4 usages found)
dolphinscheduler-service (8 usages found)
org.apache.dolphinscheduler.service.alert (4 usages found)
AlertClientServiceTest.java (3 usages found)
ProcessAlertManagerTest.java (1 usage found)
org.apache.dolphinscheduler.service.log (3 usages found)
LogClientServiceTest.java (3 usages found)
org.apache.dolphinscheduler.service.process (1 usage found)
ProcessServiceTest.java (1 usage found)
dolphinscheduler-task-dvc (5 usages found)
org.apache.dolphinscheduler.plugin.task.dvc (5 usages found)
DvcTaskTest.java (5 usages found)
dolphinscheduler-task-emr (8 usages found)
org.apache.dolphinscheduler.plugin.task.emr (8 usages found)
EmrAddStepsTaskTest.java (4 usages found)
EmrJobFlowTaskTest.java (4 usages found)
dolphinscheduler-task-jupyter (5 usages found)
org.apache.dolphinscheduler.plugin.task.jupyter (5 usages found)
JupyterTaskTest.java (5 usages found)
dolphinscheduler-task-mlflow (5 usages found)
org.apache.dolphinler.plugin.task.mlflow (5 usages found)
MlflowTaskTest.java (5 usages found)
dolphinscheduler-task-openmldb (1 usage found)
org.apache.dolphinscheduler.plugin.task.openmldb (1 usage found)
OpenmldbTaskTest.java (1 usage found)
dolphinscheduler-task-python (1 usage found)
org.apache.dolphinscheduler.plugin.task.python (1 usage found)
PythonTaskTest.java (1 usage found)
dolphinscheduler-task-sagemaker (5 usages found)
org.apache.dolphinscheduler.plugin.task.sagemaker (5 usages found)
SagemakerTaskTest.java (5 usages found)
dolphinscheduler-task-spark (4 usages found)
org.apache.dolphinscheduler.plugin.task.spark (4 usages found)
SparkTaskTest.java (4 usages found)
dolphinscheduler-task-zeppelin (4 usages found)
org.apache.dolphinscheduler.plugin.task.zeppelin (4 usages found)
ZeppelinTaskTest.java (4 usages found)
dolphinscheduler-worker (4 usages found)
org.apache.dolphinscheduler.server.worker.processor (3 usages found)
TaskDispatchProcessorTest.java (3 usages found)
org.apache.dolphinscheduler.server.worker.runner (1 usage found)
TaskExecuteThreadTest.java (1 usage found)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1253118984
> LGTM, in this PR we upgrade the unit version to `5.9.0`, and we still keep the powermock(Hope we can remove powermock in the later pr).
@ruanwenjun Certainly we will remove `powermock` in the whole project soon and I will add a spotless step to block it in DS. Removing `powermock` is of the top priority for DSIP-10 #10573 . BTW, I just found that there had been both jUnit 4 and jUnit 5 style tests in DS project for a long time. see: https://github.com/apache/dolphinscheduler/pull/12062#issuecomment-1251952599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org