You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "LiuShuangBJ (via GitHub)" <gi...@apache.org> on 2023/10/16 06:43:12 UTC
[PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
LiuShuangBJ opened a new pull request, #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
i try to fix #15029
When Output parameter is not Direct connection to the SubProcess, the parameter will be lost.
## Brief change log
<!--*(for example:)*
- *change the subProcess joinVarPool logic in ProcessServiceImpl.java*
- *change the subProcess finished then setVarPool in SubWorkflowAsyncTaskExecuteFunction.java*
- *judge the taskType and set the varPool of taskExecutionContext,beacuse the varpool of subProcess is in sub workflow, not in task ,so change MasterTaskExecuteRunnable.java"
- *改变subProcess设置varPool的逻辑 在ProcessServiceImpl.java*
- *改变subProcess任务结束后varPool的设置逻辑,从worker flow中获取最新的varPool并更新 SubWorkflowAsyncTaskExecuteFunction.java 和 MasterTaskExecuteRunnable.java*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on code in PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1405533542
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance = processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null && subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
I have more than 40 overall task nodes, so in order to visually represent the overall process, except for the logical judgment node, my other nodes are subProcess. The tasks in subProcess will have results output for the logical nodes to make judgments. The logical node accepts the varPool of subProcess's taskInstance, so the output parameters generated internally by subProcess are updated here.
中文翻译:我整体的任务节点有40多个,所以为了直观地表示整体流程,除了逻辑判断节点之外,我其他的节点都是subProcess,在subProcess中的任务会有结果输出,供逻辑节点进行判断,而逻辑节点接受的是subProcess的taskInstance的varPool,所以在这里更新subProcess内部产生的输出参数
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance = processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null && subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
I have more than 40 overall task nodes, so in order to visually represent the overall process, except for the logical judgment node, my other nodes are subProcess. The tasks in subProcess will have results output for the logical nodes to make judgments. The logical node accepts the varPool of subProcess's taskInstance, so the output parameters generated internally by subProcess are updated here.
中文翻译:我整体的任务节点有40多个,所以为了直观地表示整体流程,除了逻辑判断节点之外,我其他的节点都是subProcess,在subProcess中的任务会有结果输出,供逻辑节点进行判断,而逻辑节点接受的是subProcess的taskInstance的varPool,所以在这里更新subProcess内部产生的输出参数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831832853
> > > hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> > > <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0">
> >
> >
> > The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
>
> > > hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> > > <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0">
> >
> >
> > The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
>
> hi @ruanwenjun I think subprocess's support for localParam is another issue. I think that even if subprocess does not support localParam, the varPool of the parent process instance can be passed to the subprocess instance. WDYT? cc @LiuShuangBJ
My 40 task nodes will make the overall process very messy, so I divided the 40 task nodes into 9 subProcesses through the module. In the main process, I select the branch through the switch node, and the parameters of the switch judgment condition are determined by the subProcess. Task output, so I think this logic is necessary because I output the parameters in subProcess
中文翻译:
我40个任务节点会显得总流程很凌乱,所以我通过模块将40个任务节点划分成了9个subProcess,在主流程中经过switch节点选择分支,而switch的判断条件的参数是由subProcess中的任务输出的,所以我认为这段逻辑很有必要,因为我在subProcess中输出了参数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831837518
i really want to be a contributor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831626051
> But I think when editing a long and complex workflow, the editor will think that he has defined the output parameters in the overall workflow, and will use them in subsequent nodes, and will not deliberately define them again in subProcess. The outParam parameter is output again, which is also the opportunity when I discovered this bug. 中文翻译: 但是我觉得在编辑一条长且复杂的工作流时,编辑人员会认为自己已经在整体的工作流中 定义了输出参数,就会在后续的节点中使用,并不会刻意的在subProcess中再次定义outParam参数再做一次输出,这也是我当时发现这个bug的契机
+1 , so this is why i think the varPool of the parent process instance can be passed to the subprocess instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831835767
I turned off this merge, and then added a new optimization merge for the logic of the output parameters in subProcess.
中文翻译:
所以 是不是我应该关了这个merge,然后将subProcess中输出参数的逻辑新提一个优化merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1826348964
> hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0">
The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
> hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjM1ODAsIm5iZiI6MTcwMDkyMzI4MCwicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0NDEyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiNmM5ZDE0N2U4M2ExNTQ0OGY0MDYwM2MwODA2MTk1Y2Y3MzA4MGJjYTRmYWM4NDFlMTVlNDQ1NjlhNjMyZTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.JKoW8WLsQaa7IXgorSzabY9vBDPhcb-ZaRUMOxHOUj8">
The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1405125866
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance = processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null && subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
Yes, we need to set the variable in the task instance, since we didn't have a good way in the engine, this should be refactor after `Master refactor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on code in PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#discussion_r1404711107
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowAsyncTaskExecuteFunction.java:
##########
@@ -55,6 +55,8 @@ public SubWorkflowAsyncTaskExecuteFunction(TaskExecutionContext taskExecutionCon
}
subWorkflowInstance = processInstanceDao.queryById(subWorkflowInstance.getId());
if (subWorkflowInstance != null && subWorkflowInstance.getState().isFinished()) {
+ // update the varPool of sub workflow
+ taskExecutionContext.setVarPool(subWorkflowInstance.getVarPool());
Review Comment:
This block is a method to obtain status. Why do you need to set variables here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1831615226
> > hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> > <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0">
>
> The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
> > hi @LiuShuangBJ I think that when creating the command of the subprocess, it is enough to pass the out type parameters of the parent process. As far as I know, the subprocess does not send custom parameters, so the localparams is Null. Maybe get the varPool of the task to fill it. cc @ruanwenjun @EricGao888 WDYT
> > <img alt="image" width="971" src="https://private-user-images.githubusercontent.com/33984497/285563063-245a251e-6591-43a0-9d14-e0fdbca70a46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDA5MjMwODcsIm5iZiI6MTcwMDkyMjc4NywicGF0aCI6Ii8zMzk4NDQ5Ny8yODU1NjMwNjMtMjQ1YTI1MWUtNjU5MS00M2EwLTlkMTQtZTBmZGJjYTcwYTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI1VDE0MzMwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5Njg2ZGVlZjA2NjhiZjQzYjRlYzY4MDk1YmFiNjJkYzMzNGRkNWFiY2ZhYjljZTJiMWU4MWE5NmU2MTBkNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xqiw3B6YprCnffk108gNYnMK9YBsMR_CqunBPJvtw_0">
>
> The right way is make sub task plugin can set in and out, otherwise it's difficult to know what should send to sub workflow, and what is the workflow will output, the logic should be same with other task plugin.
hi @ruanwenjun I think subprocess's support for localParam is another issue. I think that even if subprocess does not support localParam, the varPool of the parent process instance can be passed to the subprocess instance. WDYT? cc @LiuShuangBJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ closed pull request #15031: [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess
URL: https://github.com/apache/dolphinscheduler/pull/15031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1826351231
But I think when editing a long and complex workflow, the editor will think that he has defined the output parameters in the overall workflow, and will use them in subsequent nodes, and will not deliberately define them again in subProcess. The outParam parameter is output again, which is also the opportunity when I discovered this bug.
中文翻译:
但是我觉得在编辑一条长且复杂的工作流时,编辑人员会认为自己已经在整体的工作流中 定义了输出参数,就会在后续的节点中使用,并不会刻意的在subProcess中再次定义outParam参数再做一次输出,这也是我当时发现这个bug的契机
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1826351600
So I think this logic is very necessary
中文翻译:所以我认为这段逻辑很有必要
<img width="1505" alt="image" src="https://github.com/apache/dolphinscheduler/assets/142294782/5b23f153-3057-4f78-99de-514a3bde3281">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-15029][master] fix subprocess lost output parameter which is not direct connectioned to subProcess [dolphinscheduler]
Posted by "LiuShuangBJ (via GitHub)" <gi...@apache.org>.
LiuShuangBJ commented on PR #15031:
URL: https://github.com/apache/dolphinscheduler/pull/15031#issuecomment-1826350420
OK, I close this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org