You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jiayu Liu <ji...@hey.com.INVALID> on 2022/09/16 01:02:55 UTC
Re: Dropping Java 8 support?
After 0.17 release i am proposing once again to upgrade to Java 11
minimal version. Any more feedback or concerns?
On May 14, 2022, yuxuan wang <yu...@reddit.com.invalid> wrote:
> +1 for using jdk11 to build jdk8 compatible jar for now, and dropping
> jdk8
> support later (we are already planning/working on migrating to jdk11
> internally).
>
> On Fri, May 13, 2022 at 1:25 AM Christopher <ct...@apache.org>
> wrote:
>
> > On Fri, May 13, 2022 at 1:20 AM Jiayu Liu <ji...@hey.com.invalid>
> wrote:
> > >
> > > Regarding point 2 - the lib/kotlin has its own cross tests which
> tests
> > > kotlin generator code, the lib/java has all along had its own
> cross
> > > tests, which currently live in lib/java/src/crossTests. These two
> are
> > > not related.
> >
> > Thanks for the clarification.
> >
> > >
> > > Regarding point 3 - the added module does not contain libthrift
> code but
> > > only the parts that are JDK11 specific for example the new JDK
> http
> > > client. I did not mean to compile the same code using two
> different
> > > targets but rather split out JDK11 Api dependent code so the
> libthrift
> > > continues to run on Java 8
> >
> > Okay, I understand now. Thanks. Right now, there isn't any JDK11 API
> > dependent code. If we reach the point where somebody wants to write
> > some for a feature that is exclusive to JDK 11 and later, then I
> think
> > that would be a good reason to consider dropping 8, rather than
> > maintain two.
> >
Re: Dropping Java 8 support?
Posted by Mario Emmenlauer <ma...@emmenlauer.de>.
On 16.09.22 03:02, Jiayu Liu wrote:
> After 0.17 release i am proposing once again to upgrade to Java 11
> minimal version. Any more feedback or concerns?
That sounds good for me! Thanks for looking into this!
All the best,
Mario
Re: Dropping Java 8 support?
Posted by Jiayu Liu <ji...@hey.com.INVALID>.
Hi there has been an update on this topic at
https://github.com/apache/thrift/pull/2785 - feel free to chime in and
provide additional context and discuss.
On September 16, 2022, yuxuan wang <yu...@reddit.com.invalid>
wrote:
> no objections from me :)
>
> thank you for looking into it!
>
> On Thu, Sep 15, 2022 at 6:03 PM Jiayu Liu <ji...@hey.com.invalid>
> wrote:
>
> > After 0.17 release i am proposing once again to upgrade to Java 11
> > minimal version. Any more feedback or concerns?
> >
> > On May 14, 2022, yuxuan wang <yu...@reddit.com.invalid> wrote:
> > > +1 for using jdk11 to build jdk8 compatible jar for now, and
> dropping
> > > jdk8
> > > support later (we are already planning/working on migrating to
> jdk11
> > > internally).
> > >
> > > On Fri, May 13, 2022 at 1:25 AM Christopher <ct...@apache.org>
> > > wrote:
> > >
> > > > On Fri, May 13, 2022 at 1:20 AM Jiayu Liu
> <ji...@hey.com.invalid>
> > > wrote:
> > > > >
> > > > > Regarding point 2 - the lib/kotlin has its own cross tests
> which
> > > tests
> > > > > kotlin generator code, the lib/java has all along had its own
> > > cross
> > > > > tests, which currently live in lib/java/src/crossTests. These
> two
> > > are
> > > > > not related.
> > > >
> > > > Thanks for the clarification.
> > > >
> > > > >
> > > > > Regarding point 3 - the added module does not contain
> libthrift
> > > code but
> > > > > only the parts that are JDK11 specific for example the new JDK
> > > http
> > > > > client. I did not mean to compile the same code using two
> > > different
> > > > > targets but rather split out JDK11 Api dependent code so the
> > > libthrift
> > > > > continues to run on Java 8
> > > >
> > > > Okay, I understand now. Thanks. Right now, there isn't any JDK11
> API
> > > > dependent code. If we reach the point where somebody wants to
> write
> > > > some for a feature that is exclusive to JDK 11 and later, then I
> > > think
> > > > that would be a good reason to consider dropping 8, rather than
> > > > maintain two.
> > > >
> >
--
Sent with HEY <https://hey.com/sent>
Re: Dropping Java 8 support?
Posted by Yuxuan Wang <yu...@reddit.com.INVALID>.
no objections from me :)
thank you for looking into it!
On Thu, Sep 15, 2022 at 6:03 PM Jiayu Liu <ji...@hey.com.invalid> wrote:
> After 0.17 release i am proposing once again to upgrade to Java 11
> minimal version. Any more feedback or concerns?
>
> On May 14, 2022, yuxuan wang <yu...@reddit.com.invalid> wrote:
> > +1 for using jdk11 to build jdk8 compatible jar for now, and dropping
> > jdk8
> > support later (we are already planning/working on migrating to jdk11
> > internally).
> >
> > On Fri, May 13, 2022 at 1:25 AM Christopher <ct...@apache.org>
> > wrote:
> >
> > > On Fri, May 13, 2022 at 1:20 AM Jiayu Liu <ji...@hey.com.invalid>
> > wrote:
> > > >
> > > > Regarding point 2 - the lib/kotlin has its own cross tests which
> > tests
> > > > kotlin generator code, the lib/java has all along had its own
> > cross
> > > > tests, which currently live in lib/java/src/crossTests. These two
> > are
> > > > not related.
> > >
> > > Thanks for the clarification.
> > >
> > > >
> > > > Regarding point 3 - the added module does not contain libthrift
> > code but
> > > > only the parts that are JDK11 specific for example the new JDK
> > http
> > > > client. I did not mean to compile the same code using two
> > different
> > > > targets but rather split out JDK11 Api dependent code so the
> > libthrift
> > > > continues to run on Java 8
> > >
> > > Okay, I understand now. Thanks. Right now, there isn't any JDK11 API
> > > dependent code. If we reach the point where somebody wants to write
> > > some for a feature that is exclusive to JDK 11 and later, then I
> > think
> > > that would be a good reason to consider dropping 8, rather than
> > > maintain two.
> > >
>