[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #94: Adds whitelist for custom serializer of classes in pekko package

[GitBox <gi...@apache.org>]

pjfanning commented on code in PR #94:
URL: https://github.com/apache/incubator-pekko/pull/94#discussion_r1064481159


##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -457,8 +454,12 @@ class Serialization(val system: ExtendedActorSystem) extends Extension {
     }
   }
 
+  @nowarn("msg=deprecated")
   private def warnUnexpectedNonAkkaSerializer(clazz: Class[_], ser: Serializer): Boolean = {

Review Comment:
   Could we change the function name to use 'NonPekko'?



##########
actor/src/main/resources/reference.conf:
##########
@@ -739,6 +739,9 @@ pekko {
     # to reduce noise.
     warn-on-no-serialization-verification = on
 
+    # list of fqcn of classes that may use non-pekko serializer within pekko package without warn log
+    warn-non-pekko-serializer-whitelist = ${?akka.actor.warn-non-pekko-serializer-whitelist} []

Review Comment:
   Could we call this an `allow-list` instead of `whitelist` - to avoid the connotations about colors?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org