You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/04 21:56:51 UTC

[GitHub] [tvm] areusch opened a new pull request #7407: Generate JUnitXML from pytest

areusch opened a new pull request #7407:
URL: https://github.com/apache/tvm/pull/7407


   This change produces JUnitXML from all of our pytest invocations. XML is stored in build/pytest-results for now. This should give us more visibility into which tests are failing and historical test runtime through Jenkins plugins.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on a change in pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#discussion_r571177032



##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -27,4 +27,18 @@ fi
 set -u
 
 export TVM_PATH=`pwd`
-export PYTHONPATH=${TVM_PATH}/python
+export PYTHONPATH="${TVM_PATH}/python"
+
+export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
+mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+
+function run_pytest() {
+    test_suite_name="$1"
+    shift
+    for ffi_type in ${TVM_PYTEST_FFI_TYPES:-ctypes cython}; do
+        TVM_FFI=${ffi_type} python3 -m pytest \
+           -o "junit_suite_name=${test_suite_name}-ctypes" \

Review comment:
       ```suggestion
              -o "junit_suite_name=${test_suite_name}-${TVM_PYTEST_FFI_TYPES}" \
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#issuecomment-773629839


   @tqchen @junrushao1994


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#issuecomment-773629839


   @tqchen @junrushao1994


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#issuecomment-775362363


   @tkonolige Would you mind taking a second review? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7407:
URL: https://github.com/apache/tvm/pull/7407


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on a change in pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#discussion_r571248396



##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -27,4 +27,18 @@ fi
 set -u
 
 export TVM_PATH=`pwd`
-export PYTHONPATH=${TVM_PATH}/python
+export PYTHONPATH="${TVM_PATH}/python"
+
+export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
+mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+
+function run_pytest() {
+    test_suite_name="$1"
+    shift
+    for ffi_type in ${TVM_PYTEST_FFI_TYPES:-ctypes cython}; do
+        TVM_FFI=${ffi_type} python3 -m pytest \
+           -o "junit_suite_name=${test_suite_name}-ctypes" \

Review comment:
       good catch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on a change in pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#discussion_r571177032



##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -27,4 +27,18 @@ fi
 set -u
 
 export TVM_PATH=`pwd`
-export PYTHONPATH=${TVM_PATH}/python
+export PYTHONPATH="${TVM_PATH}/python"
+
+export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
+mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+
+function run_pytest() {
+    test_suite_name="$1"
+    shift
+    for ffi_type in ${TVM_PYTEST_FFI_TYPES:-ctypes cython}; do
+        TVM_FFI=${ffi_type} python3 -m pytest \
+           -o "junit_suite_name=${test_suite_name}-ctypes" \

Review comment:
       ```suggestion
              -o "junit_suite_name=${test_suite_name}-${ffi_type}" \
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7407: Generate JUnitXML from pytest

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7407:
URL: https://github.com/apache/tvm/pull/7407#issuecomment-775320910


   @tqchen @junrushao1994 merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org