You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by eh...@apache.org on 2017/05/01 02:03:39 UTC
[2/2] lucene-solr:jira/SOLR-1485: Add equality tests for
payload_score and payload_check generated queries
Add equality tests for payload_score and payload_check generated queries
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/c8db3be8
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/c8db3be8
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/c8db3be8
Branch: refs/heads/jira/SOLR-1485
Commit: c8db3be8f3a005579d2f636ea5afea62edc2f276
Parents: 8855364
Author: Erik Hatcher <eh...@apache.org>
Authored: Sun Apr 30 22:03:24 2017 -0400
Committer: Erik Hatcher <eh...@apache.org>
Committed: Sun Apr 30 22:03:24 2017 -0400
----------------------------------------------------------------------
.../apache/solr/search/QueryEqualityTest.java | 30 ++++++++++++++++++++
1 file changed, 30 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/c8db3be8/solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java b/solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java
index 78353f2..2267b94 100644
--- a/solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java
+++ b/solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java
@@ -20,6 +20,7 @@ import java.util.HashSet;
import java.util.Map;
import java.util.Set;
+import junit.framework.AssertionFailedError;
import org.apache.lucene.search.Query;
import org.apache.lucene.search.QueryUtils;
import org.apache.solr.SolrTestCaseJ4;
@@ -1131,4 +1132,33 @@ public class QueryEqualityTest extends SolrTestCaseJ4 {
req.close();
}
}
+
+ public void testPayloadScoreQuery() throws Exception {
+ // I don't see a precedent to test query inequality in here, so doing a `try`
+ // There was a bug with PayloadScoreQuery's .equals() method that said two queries were equal with different includeSpanScore settings
+
+ try {
+ assertQueryEquals
+ (null
+ , "{!payload_score f=foo_dpf v=query func=min includeSpanScore=false}"
+ , "{!payload_score f=foo_dpf v=query func=min includeSpanScore=true}"
+ );
+ fail("queries should not have been equal");
+ } catch(AssertionFailedError e) {
+ assertTrue("queries were not equal, as expected", true);
+ }
+ }
+
+ public void testPayloadCheckQuery() throws Exception {
+ try {
+ assertQueryEquals
+ (null
+ , "{!payload_check f=foo_dpf payloads=2}one"
+ , "{!payload_check f=foo_dpf payloads=2}two"
+ );
+ fail("queries should not have been equal");
+ } catch(AssertionFailedError e) {
+ assertTrue("queries were not equal, as expected", true);
+ }
+ }
}
\ No newline at end of file