You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/07 05:04:35 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4287: Adding dataset metadata and its utility class

codecov-io commented on issue #4287: Adding dataset metadata and its utility class
URL: https://github.com/apache/incubator-pinot/pull/4287#issuecomment-499757703
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=h1) Report
   > Merging [#4287](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/fb086485d3a092914942c579b630a46ca2f22ac5?src=pr&el=desc) will **increase** coverage by `10.14%`.
   > The diff coverage is `39.02%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4287/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #4287       +/-   ##
   ============================================
   + Coverage     57.15%   67.3%   +10.14%     
     Complexity       20      20               
   ============================================
     Files          1040    1042        +2     
     Lines         51629   51670       +41     
     Branches       7232    7236        +4     
   ============================================
   + Hits          29507   34774     +5267     
   + Misses        19941   14502     -5439     
   - Partials       2181    2394      +213
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ache/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvWktNZXRhZGF0YVByb3ZpZGVyLmphdmE=) | `67.39% <0%> (+3.1%)` | `0 <0> (ø)` | :arrow_down: |
   | [...t/common/metadata/dataset/DatasetMetadataUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvZGF0YXNldC9EYXRhc2V0TWV0YWRhdGFVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...pinot/common/metadata/dataset/DatasetMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvZGF0YXNldC9EYXRhc2V0TWV0YWRhdGEuamF2YQ==) | `55.17% <55.17%> (ø)` | `0 <0> (?)` | |
   | [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `88% <0%> (-12%)` | `0% <0%> (ø)` | |
   | [...nsport/netty/PooledNettyClientResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvUG9vbGVkTmV0dHlDbGllbnRSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `85.41% <0%> (-4.17%)` | `0% <0%> (ø)` | |
   | [...inot/transport/netty/NettyTCPClientConnection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvTmV0dHlUQ1BDbGllbnRDb25uZWN0aW9uLmphdmE=) | `81.45% <0%> (-3.32%)` | `0% <0%> (ø)` | |
   | [...ator/transform/function/BaseTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQmFzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `29.95% <0%> (+0.42%)` | `0% <0%> (ø)` | :arrow_down: |
   | [...regation/function/customobject/QuantileDigest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvUXVhbnRpbGVEaWdlc3QuamF2YQ==) | `58.18% <0%> (+0.44%)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [327 more](https://codecov.io/gh/apache/incubator-pinot/pull/4287/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=footer). Last update [fb08648...aaa9416](https://codecov.io/gh/apache/incubator-pinot/pull/4287?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org