[GitHub] [arrow] yevgenypats commented on a diff in pull request #34585: GH-34584: [Go][CSV] Add extension types support

["yevgenypats (via GitHub)" <gi...@apache.org>]

yevgenypats commented on code in PR #34585:
URL: https://github.com/apache/arrow/pull/34585#discussion_r1143314586


##########
go/arrow/csv/reader.go:
##########
@@ -773,6 +778,18 @@ func (r *Reader) parseBinaryType(field array.Builder, str string) {
 	field.(*array.BinaryBuilder).Append(decodedVal)
 }
 
+func (r *Reader) parseExtension(field array.Builder, str string) {
+	if r.isNull(str) {
+		field.AppendNull()
+		return
+	}
+	dec := json.NewDecoder(strings.NewReader(`"` + str + `"`))

Review Comment:
   Given this is a reader and it comes from the CSV it will always be a string, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org