You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/27 18:58:53 UTC

[GitHub] [beam] rohdesamuel opened a new pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

rohdesamuel opened a new pull request #12703:
URL: https://github.com/apache/beam/pull/12703


   Change-Id: I414463dc40a58c1452b7f4a6e819b9e054e4cac8
   
   This adds the ability to introspect into the RecordingManager to get the start time and size on cache for a recording or pipeline (RecordingManager). Also adds the "cancel" method to a recording. This allows to gracefully shutdown a recording if a kernel interrupt is caught.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace
   --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   ![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg)
   ![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-685059760


   Run Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.09%   -0.14%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54046     +377     
   ==========================================
   + Hits        21587    21668      +81     
   - Misses      32082    32378     +296     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684058731


   Run Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...835d086](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-685998192


   Run PythonDocker PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r482445684



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -258,16 +278,46 @@ def _watch(self, pcolls):
         ie.current_env().watch(
             {'anonymous_pcollection_{}'.format(id(pcoll)): pcoll})
 
-  def clear(self, pcolls):
+  def _clear(self, pipeline_instrument):
     # type: (List[beam.pvalue.PCollection]) -> None
 
-    """Clears the cache of the given PCollections."""
+    """Clears the recording of all non-source PCollections."""
 
     cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
-    for pc in pcolls:
-      cache_key = self._pipeline_instrument.cache_key(pc)
+
+    # Only clear the PCollections that aren't being populated from the
+    # BackgroundCachingJob.
+    all_cached = set(
+        str(c.to_key()) for c in pipeline_instrument.cacheables.values())
+    source_pcolls = getattr(cache_manager, 'capture_keys', set())
+    to_clear = all_cached - source_pcolls
+
+    for cache_key in to_clear:
       cache_manager.clear('full', cache_key)
 
+  def cancel(self):
+    # type: (None) -> None
+
+    """Cancels the current background recording job."""
+
+    bcj = ie.current_env().get_background_caching_job(self.user_pipeline)
+    if bcj:
+      bcj.cancel()

Review comment:
       Great, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
KevinGG commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r482393739



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -258,16 +278,46 @@ def _watch(self, pcolls):
         ie.current_env().watch(
             {'anonymous_pcollection_{}'.format(id(pcoll)): pcoll})
 
-  def clear(self, pcolls):
+  def _clear(self, pipeline_instrument):
     # type: (List[beam.pvalue.PCollection]) -> None
 
-    """Clears the cache of the given PCollections."""
+    """Clears the recording of all non-source PCollections."""
 
     cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
-    for pc in pcolls:
-      cache_key = self._pipeline_instrument.cache_key(pc)
+
+    # Only clear the PCollections that aren't being populated from the
+    # BackgroundCachingJob.
+    all_cached = set(
+        str(c.to_key()) for c in pipeline_instrument.cacheables.values())
+    source_pcolls = getattr(cache_manager, 'capture_keys', set())
+    to_clear = all_cached - source_pcolls
+
+    for cache_key in to_clear:
       cache_manager.clear('full', cache_key)
 
+  def cancel(self):
+    # type: (None) -> None
+
+    """Cancels the current background recording job."""
+
+    bcj = ie.current_env().get_background_caching_job(self.user_pipeline)
+    if bcj:
+      bcj.cancel()

Review comment:
       You can use `attempt_to_cancel_background_caching_job(user_pipeline)` https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/interactive/background_caching_job.py#L220




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-685914577


   Run Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...b3011ad](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...0d7add9](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-685998125


   Run Portable_Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #12703:
URL: https://github.com/apache/beam/pull/12703


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-686690298






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-685130256






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-686041445


   R: @pabloem 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r482446680



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py
##########
@@ -288,18 +347,122 @@ def test_basic_wordcount(self):
     # Create the recording objects. By calling `record` a new PipelineFragment
     # is started to compute the given PCollections and cache to disk.
     rm = RecordingManager(p)
-    recording = rm.record([elems], max_n=3, max_duration_secs=500)
-    stream = recording.stream(elems)
-    recording.wait_until_finish()
+    numbers_recording = rm.record([numbers], max_n=3, max_duration_secs=500)
+    numbers_stream = numbers_recording.stream(numbers)
+    numbers_recording.wait_until_finish()
 
     # Once the pipeline fragment completes, we can read from the stream and know
     # that all elements were written to cache.
-    elems = list(stream.read())
+    elems = list(numbers_stream.read())
     expected_elems = [
         WindowedValue(i, MIN_TIMESTAMP, [GlobalWindow()]) for i in range(3)
     ]
     self.assertListEqual(elems, expected_elems)
 
+    # Make an extra recording and test the description.
+    letters_recording = rm.record([letters], max_n=3, max_duration_secs=500)
+    letters_recording.wait_until_finish()
+
+    self.assertEqual(
+        rm.describe()['size'],
+        numbers_recording.describe()['size'] +
+        letters_recording.describe()['size'])
+
+    rm.cancel()
+
+  @unittest.skipIf(
+      sys.version_info < (3, 6, 0),
+      'This test requires at least Python 3.6 to work.')
+  def test_cancel_stops_recording(self):
+    # Add the TestStream so that it can be cached.
+    ib.options.capturable_sources.add(TestStream)
+
+    p = beam.Pipeline(
+        InteractiveRunner(), options=PipelineOptions(streaming=True))
+    elems = (
+        p
+        | TestStream().advance_watermark_to(0).advance_processing_time(
+            1).add_elements(list(range(10))).advance_processing_time(1))
+    squares = elems | beam.Map(lambda x: x**2)
+
+    # Watch the local scope for Interactive Beam so that referenced PCollections
+    # will be cached.
+    ib.watch(locals())
+
+    # This is normally done in the interactive_utils when a transform is
+    # applied but needs an IPython environment. So we manually run this here.
+    ie.current_env().track_user_pipelines()
+
+    # Get the recording then the BackgroundCachingJob.

Review comment:
       For the time being yes, but this will be changed later on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-686017960


   Run PythonDocker PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...835d086](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.09%   -0.14%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54046     +377     
   ==========================================
   + Hits        21587    21668      +81     
   - Misses      32082    32378     +296     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...0d7add9](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r485084128



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -258,16 +278,44 @@ def _watch(self, pcolls):
         ie.current_env().watch(
             {'anonymous_pcollection_{}'.format(id(pcoll)): pcoll})
 
-  def clear(self, pcolls):
+  def _clear(self, pipeline_instrument):
     # type: (List[beam.pvalue.PCollection]) -> None
 
-    """Clears the cache of the given PCollections."""
+    """Clears the recording of all non-source PCollections."""
 
     cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
-    for pc in pcolls:
-      cache_key = self._pipeline_instrument.cache_key(pc)
+
+    # Only clear the PCollections that aren't being populated from the
+    # BackgroundCachingJob.
+    all_cached = set(
+        str(c.to_key()) for c in pipeline_instrument.cacheables.values())

Review comment:
       Gotcha, I can make a follow-up PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] davidyan74 commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
davidyan74 commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r482420061



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py
##########
@@ -288,18 +347,122 @@ def test_basic_wordcount(self):
     # Create the recording objects. By calling `record` a new PipelineFragment
     # is started to compute the given PCollections and cache to disk.
     rm = RecordingManager(p)
-    recording = rm.record([elems], max_n=3, max_duration_secs=500)
-    stream = recording.stream(elems)
-    recording.wait_until_finish()
+    numbers_recording = rm.record([numbers], max_n=3, max_duration_secs=500)
+    numbers_stream = numbers_recording.stream(numbers)
+    numbers_recording.wait_until_finish()
 
     # Once the pipeline fragment completes, we can read from the stream and know
     # that all elements were written to cache.
-    elems = list(stream.read())
+    elems = list(numbers_stream.read())
     expected_elems = [
         WindowedValue(i, MIN_TIMESTAMP, [GlobalWindow()]) for i in range(3)
     ]
     self.assertListEqual(elems, expected_elems)
 
+    # Make an extra recording and test the description.
+    letters_recording = rm.record([letters], max_n=3, max_duration_secs=500)
+    letters_recording.wait_until_finish()
+
+    self.assertEqual(
+        rm.describe()['size'],
+        numbers_recording.describe()['size'] +
+        letters_recording.describe()['size'])
+
+    rm.cancel()
+
+  @unittest.skipIf(
+      sys.version_info < (3, 6, 0),
+      'This test requires at least Python 3.6 to work.')
+  def test_cancel_stops_recording(self):
+    # Add the TestStream so that it can be cached.
+    ib.options.capturable_sources.add(TestStream)
+
+    p = beam.Pipeline(
+        InteractiveRunner(), options=PipelineOptions(streaming=True))
+    elems = (
+        p
+        | TestStream().advance_watermark_to(0).advance_processing_time(
+            1).add_elements(list(range(10))).advance_processing_time(1))
+    squares = elems | beam.Map(lambda x: x**2)
+
+    # Watch the local scope for Interactive Beam so that referenced PCollections
+    # will be cached.
+    ib.watch(locals())
+
+    # This is normally done in the interactive_utils when a transform is
+    # applied but needs an IPython environment. So we manually run this here.
+    ie.current_env().track_user_pipelines()
+
+    # Get the recording then the BackgroundCachingJob.

Review comment:
       Are we still calling it BackgroundCachingJob?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...b3011ad](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...0d7add9](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.09%   -0.14%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    54046     +377     
   ==========================================
   + Hits        21587    21668      +81     
   - Misses      32082    32378     +296     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (+0.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-683998574


   Run Portable_Python PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r482544524



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -63,6 +63,12 @@ def var(self):
     """Returns the variable named that defined this PCollection."""
     return self._var
 
+  def cache_key(self):

Review comment:
       Generally doing this is not necessary. You can name the attribute `self.cache_key`, and users can access the attribute directly, unless there's a strong reason not to.

##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -258,16 +278,44 @@ def _watch(self, pcolls):
         ie.current_env().watch(
             {'anonymous_pcollection_{}'.format(id(pcoll)): pcoll})
 
-  def clear(self, pcolls):
+  def _clear(self, pipeline_instrument):
     # type: (List[beam.pvalue.PCollection]) -> None
 
-    """Clears the cache of the given PCollections."""
+    """Clears the recording of all non-source PCollections."""
 
     cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
-    for pc in pcolls:
-      cache_key = self._pipeline_instrument.cache_key(pc)
+
+    # Only clear the PCollections that aren't being populated from the
+    # BackgroundCachingJob.
+    all_cached = set(
+        str(c.to_key()) for c in pipeline_instrument.cacheables.values())

Review comment:
       It's a little unsafe to use string representation as keys, no? Should CacheKey implement a hash method instead?

##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -258,16 +278,44 @@ def _watch(self, pcolls):
         ie.current_env().watch(
             {'anonymous_pcollection_{}'.format(id(pcoll)): pcoll})
 
-  def clear(self, pcolls):
+  def _clear(self, pipeline_instrument):
     # type: (List[beam.pvalue.PCollection]) -> None
 
-    """Clears the cache of the given PCollections."""
+    """Clears the recording of all non-source PCollections."""
 
     cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
-    for pc in pcolls:
-      cache_key = self._pipeline_instrument.cache_key(pc)
+
+    # Only clear the PCollections that aren't being populated from the
+    # BackgroundCachingJob.
+    all_cached = set(
+        str(c.to_key()) for c in pipeline_instrument.cacheables.values())

Review comment:
       It seems that we're using the string representation everywhere, so it may represent a large change - and I see it;s a carefully written repr method, so it's not necessary for this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/aa345dbeb9f6bdb36f5acf0fb8958777253acd51?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `15.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   - Coverage   40.22%   40.21%   -0.02%     
   ==========================================
     Files         454      454              
     Lines       53669    53695      +26     
   ==========================================
   + Hits        21587    21592       +5     
   - Misses      32082    32103      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `27.70% <14.70%> (-1.90%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...a4dcca4](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...0d7add9](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12703      +/-   ##
   ==========================================
   + Coverage   40.22%   40.26%   +0.04%     
   ==========================================
     Files         454      455       +1     
     Lines       53669    53847     +178     
   ==========================================
   + Hits        21587    21681      +94     
   - Misses      32082    32166      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.05% <20.58%> (-0.55%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
   | [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `23.36% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `28.92% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...835d086](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rohdesamuel commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #12703:
URL: https://github.com/apache/beam/pull/12703#discussion_r485108295



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -63,6 +63,12 @@ def var(self):
     """Returns the variable named that defined this PCollection."""
     return self._var
 
+  def cache_key(self):

Review comment:
       Gotcha, I turned this into a property. I wanted others to access the cache_key and var of the stream but without the ability for owners to modify the values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12703:
URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report
   > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/1d25e2ebeb4a0f74278dbd0cfbaa00f36abd73dc?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12703/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12703   +/-   ##
   =======================================
     Coverage   40.22%   40.22%           
   =======================================
     Files         454      455    +1     
     Lines       53669    53754   +85     
   =======================================
   + Hits        21587    21624   +37     
   - Misses      32082    32130   +48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `25.00% <0.00%> (-0.25%)` | :arrow_down: |
   | [...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=) | `40.32% <0.00%> (ø)` | |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `28.08% <15.62%> (-1.52%)` | :arrow_down: |
   | [...he\_beam/runners/interactive/pipeline\_instrument.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9pbnN0cnVtZW50LnB5) | `14.86% <50.00%> (+0.16%)` | :arrow_up: |
   | [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `41.17% <0.00%> (-1.58%)` | :arrow_down: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/kinesis.py](https://codecov.io/gh/apache/beam/pull/12703/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2luZXNpcy5weQ==) | `66.66% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=footer). Last update [31af8b1...ab76559](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org