[GitHub] [hadoop] Daniel-009497 commented on a diff in pull request #5238: YARN-11400 The residual data stored in leveldb for finished containers should be cleared in the NodeManager heartbeat response…

[GitBox <gi...@apache.org>]

Daniel-009497 commented on code in PR #5238:
URL: https://github.com/apache/hadoop/pull/5238#discussion_r1051771069


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -717,6 +717,8 @@ public void removeOrTrackCompletedContainersFromContext(
         org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerState.DONE)) {
         context.getContainers().remove(containerId);
         removedContainers.add(containerId);
+        // For the finished containers, the residual data stored in leveldb should also be cleared
+        addCompletedContainer(containerId);

Review Comment:
   Thanks for your review.
   Cleaning up here is just be added into a map which will be handled asynchronously and no exception could be thrown here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org