You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2022/01/13 22:43:00 UTC

[jira] [Comment Edited] (CASSANDRA-17233) Fix org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testNonblockingShouldMaintainSteadyDiskUsage

    [ https://issues.apache.org/jira/browse/CASSANDRA-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471254#comment-17471254 ] 

Yifan Cai edited comment on CASSANDRA-17233 at 1/13/22, 10:42 PM:
------------------------------------------------------------------

PR: https://github.com/apache/cassandra/pull/1379
CI: https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=CASSANDRA-17233%2Ftrunk&filter=all

The test failure was caused by improper cdc commit log deletion and race on updating the size. (The change was made in CASSANDRA-17001.) 
I updated the implementation of deleting the old linked CDC commit log segments to properly delete the files and update the current total size as part of the deletion since it lists the files already. 




was (Author: yifanc):
PR: https://github.com/apache/cassandra/pull/1379
CI: https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=CASSANDRA-17233%2Ftrunk&filter=all

The test failure was caused by improper cdc commit log deletion and race on updating the size. I updated the implementation of deleting the old linked CDC commit log segments to properly delete the files and update the current total size as part of the deletion since it lists the files already. 

> Fix   org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testNonblockingShouldMaintainSteadyDiskUsage
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17233
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17233
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Yifan Cai
>            Priority: Normal
>             Fix For: 4.x
>
>
> Fails consistently on trunk:
> https://ci-cassandra.apache.org/job/Cassandra-trunk/893/testReport/junit/org.apache.cassandra.db.commitlog/CommitLogSegmentManagerCDCTest/testNonblockingShouldMaintainSteadyDiskUsage/history/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org