You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "gaojinchao (Created) (JIRA)" <ji...@apache.org> on 2011/11/25 09:40:40 UTC
[jira] [Created] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
-------------------------------------------------------------
Key: HBASE-4868
URL: https://issues.apache.org/jira/browse/HBASE-4868
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.92.0
Reporter: gaojinchao
Priority: Minor
Fix For: 0.94.0
looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
Please review, see whether the method makes sense?
If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gaojinchao updated HBASE-4868:
------------------------------
Status: Open (was: Patch Available)
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157550#comment-13157550 ]
Jonathan Hsieh commented on HBASE-4868:
---------------------------------------
I mis-spoke -- the timeouts are already there. Sorry about that.
The check should be added to similar spots in the tests in TestOfflineMetaRebuildHole and TestOfflineMetaRebuildOverlap -- they would likely be vulnerable to the same kind of race.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159796#comment-13159796 ]
Hudson commented on HBASE-4868:
-------------------------------
Integrated in HBase-0.92 #163 (See [https://builds.apache.org/job/HBase-0.92/163/])
HBASE-4868 TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
(Gao Jinchao)
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157392#comment-13157392 ]
Ted Yu commented on HBASE-4868:
-------------------------------
Minor comment:
{code}
- * Creates an znode with OPENED state.
+ * Gets a ZooKeeperWatcher.
{code}
I think we should say 'Creates a ZooKeeperWatcher'.
The name for the new method should be changed as well.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505254/4868-0.92.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/382//console
This message is automatically generated.)
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157400#comment-13157400 ]
Ted Yu edited comment on HBASE-4868 at 11/26/11 7:23 AM:
---------------------------------------------------------
@Test(timeout = 120000)
public void testMetaRebuild() throws Exception {
This code can't guarantee ?. I don't understand where should add?
Please remind me :)
was (Author: sunnygao):
@Test(timeout = 120000)
public void testMetaRebuild() throws Exception {
This code can't guarantee ?. I don't understand where should add?
Please remind me :)
-----邮件原件-----
发件人: Ted Yu (Commented) (JIRA) [mailto:jira@apache.org]
发送时间: 2011年11月26日 14:59
收件人: Gaojinchao
主题: [jira] [Commented] (HBASE-4868) testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157395#comment-13157395 ]
Ted Yu commented on HBASE-4868:
-------------------------------
HadoopQA is having problem - it didn't run test suite.
@Jinchao:
Please also add the timeout parameter as Jonathan suggested.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157951#comment-13157951 ]
Hudson commented on HBASE-4868:
-------------------------------
Integrated in HBase-TRUNK #2488 (See [https://builds.apache.org/job/HBase-TRUNK/2488/])
HBASE-4868 TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
(Gao Jinchao)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gaojinchao updated HBASE-4868:
------------------------------
Attachment: HBASE-4868_trunkv2.patch
Fixed the comments
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157346#comment-13157346 ]
Jonathan Hsieh commented on HBASE-4868:
---------------------------------------
@Jinchao
Also, if this is call that can indefinitely block, I'd add timeout values for the test.
So instead of just
{code}
@Test
{code}
change it to
{code}
@Test(timeout=180) // fail test after 180s
{code}
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158322#comment-13158322 ]
Hudson commented on HBASE-4868:
-------------------------------
Integrated in HBase-TRUNK-security #12 (See [https://builds.apache.org/job/HBase-TRUNK-security/12/])
HBASE-4868 TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
(Gao Jinchao)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157395#comment-13157395 ]
Ted Yu commented on HBASE-4868:
-------------------------------
HadoopQA is having problem - it didn't run test suite.
@Jinchao:
Please also add the timeout parameter as Jonathan suggested.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157206#comment-13157206 ]
Ted Yu edited comment on HBASE-4868 at 11/25/11 3:58 PM:
---------------------------------------------------------
@Jinchao:
The inner ZooKeeperWatcher is similar to the one in HBaseTestingUtility.createAndForceNodeToOpenedState().
Can you refactor the inner class in HBaseTestingUtility so that we can reuse it in other unit tests ?
Thanks
was (Author: yuzhihong@gmail.com):
+1 on patch.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Summary: TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails (was: testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails)
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157353#comment-13157353 ]
gaojinchao commented on HBASE-4868:
-----------------------------------
Thanks reveiw, I will fix all the comments
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157986#comment-13157986 ]
Hudson commented on HBASE-4868:
-------------------------------
Integrated in HBase-0.92-security #18 (See [https://builds.apache.org/job/HBase-0.92-security/18/])
HBASE-4868 TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
(Gao Jinchao)
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157393#comment-13157393 ]
Hadoop QA commented on HBASE-4868:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505176/HBASE-4868_trunkv2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/375//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/375//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/375//console
This message is automatically generated.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gaojinchao updated HBASE-4868:
------------------------------
Attachment: HBASE-4868_trial.patch
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Attachment: 4868-v3.txt
Patch v3 applies same change to TestOfflineMetaRebuildHole and TestOfflineMetaRebuildOverlap.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157922#comment-13157922 ]
Hadoop QA commented on HBASE-4868:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505254/4868-0.92.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/382//console
This message is automatically generated.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157404#comment-13157404 ]
Ted Yu commented on HBASE-4868:
-------------------------------
I see the timeout value.
@Jonathan:
Please clarify.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157267#comment-13157267 ]
ramkrishna.s.vasudevan commented on HBASE-4868:
-----------------------------------------------
@Ted
I too thought of the same.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157400#comment-13157400 ]
gaojinchao commented on HBASE-4868:
-----------------------------------
@Test(timeout = 120000)
public void testMetaRebuild() throws Exception {
This code can't guarantee ?. I don't understand where should add?
Please remind me :)
-----邮件原件-----
发件人: Ted Yu (Commented) (JIRA) [mailto:jira@apache.org]
发送时间: 2011年11月26日 14:59
收件人: Gaojinchao
主题: [jira] [Commented] (HBASE-4868) testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157395#comment-13157395 ]
Ted Yu commented on HBASE-4868:
-------------------------------
HadoopQA is having problem - it didn't run test suite.
@Jinchao:
Please also add the timeout parameter as Jonathan suggested.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157133#comment-13157133 ]
Hadoop QA commented on HBASE-4868:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505085/HBASE-4868_trial.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 66 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/365//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/365//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/365//console
This message is automatically generated.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "gaojinchao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gaojinchao updated HBASE-4868:
------------------------------
Assignee: gaojinchao
Status: Patch Available (was: Open)
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Issue Type: Test (was: Bug)
Integrated to 0.92 and TRUNK.
Thanks for the patch, Jinchao.
Thanks for the review Jonathan.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157921#comment-13157921 ]
Hadoop QA commented on HBASE-4868:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505253/4868-v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 67 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/381//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/381//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/381//console
This message is automatically generated.
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Status: Patch Available (was: Open)
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157206#comment-13157206 ]
Ted Yu commented on HBASE-4868:
-------------------------------
+1 on patch.
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Attachment: 4868-0.92.txt
> TestOfflineMetaRebuildBase#testMetaRebuild occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4868-0.92.txt, 4868-v3.txt, HBASE-4868_trial.patch, HBASE-4868_trunkv2.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4868)
testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4868:
--------------------------
Fix Version/s: 0.92.0
>From https://builds.apache.org/job/PreCommit-HBASE-Build/365//testReport/org.apache.hadoop.hbase.replication/TestMultiSlaveReplication/testMultiSlaveReplication/, I see:
{code}
2011-11-25 12:15:36,018 ERROR [org.apache.hadoop.hdfs.server.datanode.DataXceiverServer@c7057c] datanode.DataXceiverServer(145): DatanodeRegistration(127.0.0.1:56231, storageID=DS-225434506-67.195.138.20-56231-1322223310312, infoPort=41654, ipcPort=53271):DataXceiveServer: Exiting due to:java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
{code}
The other two failed tests were due to 'Too many open files'
> testMetaRebuild#TestOfflineMetaRebuildBase occasionally fails
> -------------------------------------------------------------
>
> Key: HBASE-4868
> URL: https://issues.apache.org/jira/browse/HBASE-4868
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Priority: Minor
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4868_trial.patch
>
>
> looks: https://builds.apache.org/job/HBase-TRUNK-security/7/testReport/org.apache.hadoop.hbase.util.hbck/TestOfflineMetaRebuildBase/testMetaRebuild/
> Please review, see whether the method makes sense?
> If it makes sense, I will check other cases?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira