[jira] [Updated] (LUCENE-7120) Improve BKDWriter's checksum verification

["Michael McCandless (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-7120:
---------------------------------------
    Attachment: LUCENE-7120.patch

Relatively simple patch, adding a new {{getSharedReader}} method to {{PointWriter}}, so that the sharing is explicit as we recurse.

We still eagerly close the shared readers.

> Improve BKDWriter's checksum verification
> -----------------------------------------
>
>                 Key: LUCENE-7120
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7120
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master, 6.1
>
>         Attachments: LUCENE-7120.patch
>
>
> The checksum verification only works when {{BKDWriter}} fully reads one of its temp files, but today it opens a reader, seeks to one slice, reads that, and closes.
> But it turns out, on the full recursion from any given node in the tree, a given file is read once, fully, so if we just share the readers, then we can get checksum verification for these files as well.
> This is a non-trivial change ... I don't plan on pushing it for 6.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org