You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2020/11/18 10:12:00 UTC
[jira] [Resolved] (CALCITE-2279) Druid adapter duplicate binary
expression
[ https://issues.apache.org/jira/browse/CALCITE-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stamatis Zampetakis resolved CALCITE-2279.
------------------------------------------
Fix Version/s: 1.27.0
Resolution: Fixed
Fixed in [155276591288615c4d02d55fb7d77eceb2e24b2d|https://github.com/apache/calcite/commit/155276591288615c4d02d55fb7d77eceb2e24b2d] as part of CALCITE-4314.
> Druid adapter duplicate binary expression
> -----------------------------------------
>
> Key: CALCITE-2279
> URL: https://issues.apache.org/jira/browse/CALCITE-2279
> Project: Calcite
> Issue Type: Bug
> Components: druid-adapter
> Reporter: Kevin Risden
> Assignee: Nishant Bangarwa
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.27.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I was looking into Error Prone [1] checking for Calcite and it found what looks like a bug in Druid Adapter. The output is as follows
>
> {quote}DruidJsonFilter.java:[324,9] [IdentityBinaryExpression] A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to `lhs.getType().getFamily() == SqlTypeFamily.NUMERIC`.
> [ERROR] (see [http://errorprone.info/bugpattern/IdentityBinaryExpression]){quote}
>
> The DruidJsonFilter [2] has left and right hand the exact same.
>
> [1] [http://errorprone.info/]
> [2] [https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java#L323]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)