[jira] Updated: (DBCP-343) RemoveAbandoned setting closes the active connection.

["Phil Steitz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated DBCP-343:
-----------------------------

    Attachment: removeAbandoned.patch

Sorry, penultimate comment above is incorrect.  Using a DelegatingStatement/PreparedStatement/CallableStatement does not update the lastUsed property of the parent connection.

removeAbandoned.patch modifies executeXxx methods of these classes update lastUsed on the parent connection.  Documentation is also clarified. 

If others are OK with this patch, I will apply it to both 1.x and 2.0 branches.

> RemoveAbandoned setting closes the active connection.
> -----------------------------------------------------
>
>                 Key: DBCP-343
>                 URL: https://issues.apache.org/jira/browse/DBCP-343
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.3, 1.4
>         Environment: Linux 64 bit, Ubuntu 5.*
>            Reporter: Singaravelu Suburayan
>            Priority: Blocker
>             Fix For: 1.3.1, 1.4.1
>
>         Attachments: removeAbandoned.patch
>
>
> The documentation says, RemoveAbandoned connection setting will remove only the connections that are idle for the configured timeout. But I see it is closing the connections that are active.
> The logic in DBCP implementatoin shows that it calculate the idle time from the time of the connection is created, irrespective of the connection is used. So it just close the connection in removeAbandonedTimeout.
> In my code, I'm reusing the connection for more DB statements to do intensive db operations, which hold the connection for more than 5 minutes . The connection will never be idle for more than a few seconds.
> My setting of removeabandonedTimeout = 300 brutally closes the connection in 5 minutes, without checking if the connection is in use or not.
> I assume it should involve the activity of the statement object also to do the idle time calculation.
> thanks,
> Sing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.