[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #21387: add sharding sphere data.

[GitBox <gi...@apache.org>]

strongduanmu commented on code in PR #21387:
URL: https://github.com/apache/shardingsphere/pull/21387#discussion_r990627056


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/data/ShardingSphereDataFactory.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.data;
+
+import org.apache.shardingsphere.infra.database.type.DatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.MySQLDatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.OpenGaussDatabaseType;
+import org.apache.shardingsphere.infra.database.type.dialect.PostgreSQLDatabaseType;
+import org.apache.shardingsphere.infra.metadata.ShardingSphereMetaData;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+
+import java.util.Map.Entry;
+import java.util.Optional;
+
+/**
+ * Sharding sphere data factory.
+ */
+public final class ShardingSphereDataFactory {
+    
+    private static final String SHARDING_SPHERE = "shardingsphere";
+    
+    /**
+     * Init.
+     *
+     * @param metaData meta data
+     * @return sharding sphere data
+     */
+    public static ShardingSphereData init(final ShardingSphereMetaData metaData) {
+        DatabaseType protocolType = metaData.getDatabases().values().iterator().next().getProtocolType();

Review Comment:
   Can we extract these logic to SPI implementation?



##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/data/ShardingSphereRowData.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.data;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+
+import java.util.List;
+
+/**
+ * Sharding sphere row data.
+ */
+@RequiredArgsConstructor
+@Getter
+public final class ShardingSphereRowData {
+    
+    private final List<Object> row;

Review Comment:
   Do you think rows is better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org