You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2019/08/13 13:37:50 UTC
[arrow] branch master updated: ARROW-6205: [C++] ARROW_DEPRECATED
warning when including io/interfaces.h
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new e41ad0d ARROW-6205: [C++] ARROW_DEPRECATED warning when including io/interfaces.h
e41ad0d is described below
commit e41ad0d2ccaf96812d902b161d8a0b2b372f1b72
Author: Mark Harris <mh...@nvidia.com>
AuthorDate: Tue Aug 13 08:37:36 2019 -0500
ARROW-6205: [C++] ARROW_DEPRECATED warning when including io/interfaces.h
ARROW_DEPRECATED on using statements causes warnings when including interfaces.h from CUDA source files (.cu) compiled with nvcc.
This PR works around this issue the same way it is done for MSVC by changing a single preprocessor condition.
Fixes [JIRA 6205 ](https://issues.apache.org/jira/browse/ARROW-6205?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved%20AND%20text%20~%20%22ARROW_DEPRECATED%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC)
Closes #5062 from harrism/fix-deprecated-warning-nvcc and squashes the following commits:
f4d89b310 <Mark Harris> remove deprecated aliases in interfaces.h
b129d56fb <Mark Harris> fix preprocessor macro logic
6143b462e <Mark Harris> When compiling with nvcc, don't use ARROW_DEPRECATED on using statement
Authored-by: Mark Harris <mh...@nvidia.com>
Signed-off-by: Wes McKinney <we...@apache.org>
---
cpp/src/arrow/io/interfaces.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/cpp/src/arrow/io/interfaces.h b/cpp/src/arrow/io/interfaces.h
index 3a5cfe3..678366b 100644
--- a/cpp/src/arrow/io/interfaces.h
+++ b/cpp/src/arrow/io/interfaces.h
@@ -190,16 +190,6 @@ class ARROW_EXPORT ReadWriteFileInterface : public RandomAccessFile, public Writ
ReadWriteFileInterface() { RandomAccessFile::set_mode(FileMode::READWRITE); }
};
-// TODO(kszucs): remove this after 0.13
-#ifndef _MSC_VER
-using WriteableFile ARROW_DEPRECATED("Use WritableFile") = WritableFile;
-using ReadableFileInterface ARROW_DEPRECATED("Use RandomAccessFile") = RandomAccessFile;
-#else
-// MSVC does not like using ARROW_DEPRECATED with using declarations
-using WriteableFile = WritableFile;
-using ReadableFileInterface = RandomAccessFile;
-#endif
-
} // namespace io
} // namespace arrow