[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2867: Fix bug that _min_percentage_of_error_disk was not initialized

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2867: Fix bug that _min_percentage_of_error_disk was not initialized
URL: https://github.com/apache/incubator-doris/pull/2867#discussion_r376786908
 
 

 ##########
 File path: be/src/olap/storage_engine.h
 ##########
 @@ -225,7 +224,7 @@ class StorageEngine {
 
     OLAPStatus _judge_and_update_effective_cluster_id(int32_t cluster_id);
 
-    OLAPStatus _start_bg_worker();
+    bool _too_many_disks_are_broken(uint32_t unused_num, uint32_t total_num);
 
 Review comment:
   ```suggestion
       bool _check_disks_broken_percentage(uint32_t unused_num, uint32_t total_num);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org