[jira] [Commented] (SOLR-12939) standardise test class naming

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730396#comment-16730396 ] 

Christine Poerschke commented on SOLR-12939:
--------------------------------------------

bq. ... across the entire codebase, so this should probably be a LUCENE level issue, not a SOLR issue?

Makes sense, I'll try to JIRA-move the ticket from SOLR to LUCENE, that _should_ work including forwarding of any SOLR-12939 links.

bq. ... i'm not sure if a "source" level validation will go far enough for enforcing this ...

Sure, beyond (or indeed instead of) test class name standardisation more things are possible. My intention here was purely to start somewhere.

The latest patch (SOLR-12939.03.patch) does away with the idea of explicitly enforcing a convention for the parts of the code base that already follow the convention but instead it simply overall counts un-conventionality (anti patterns). If the overall count is 'too high' (e.g. likely new test files don't follow the convention) then {{ant validate-source-patterns}} will fail e.g.
{code}
...
validate-source-patterns:

BUILD FAILED
/Users/cpoerschke/lucene-solr/build.xml:128: Found too many (1607 > 1606) anti patterns (prefer FooBarTest.java over TestFooBar.java for new tests).
...
{code}

Could such logic be helpful (in avoiding the addition of new {{TestFooBar.java}} test files) and/or might the fuzziness of the logic cause too much confusion?

bq. ... I'm attaching a patch where i breifly experimented with a groovy script ... i wanted to put this out there as a POC for thought/discussion in case anyone wants to pick it up and run with it ...

Thanks for sharing!

> standardise test class naming
> -----------------------------
>
>                 Key: SOLR-12939
>                 URL: https://issues.apache.org/jira/browse/SOLR-12939
>             Project: Solr
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Priority: Major
>         Attachments: SOLR-12939.01.patch, SOLR-12939.02.patch, SOLR-12939.03.patch, SOLR-12939_hoss_validation_groovy_experiment.patch
>
>
> This was mentioned and proposed on the dev mailing list. Starting this ticket here to start to make it happen?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org