You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/28 07:31:36 UTC
[GitHub] [airflow] potiuk opened a new pull request #12678: Changes --constraint flag into --requirement flag.
potiuk opened a new pull request #12678:
URL: https://github.com/apache/airflow/pull/12678
PIP clarified the behaviour of --constraint flag and it turned
out that the earlier behaviour where constraint files were used
was an accidental behaviour. We can have the same behaviour
by switching to --requirement flag. Note that the requirement
flag is not "permanent" it is only effective during the PIP
resolving which dependencies to install now - it does not
impose requirements for the packages being installed in the
future, which is the exact behaviour we want to get.
Here is more info about deprecating the old --constraints behaviour:
DEPRECATION: Constraints are only allowed to take the form of a package
name and a version specifier. Other forms were originally permitted
as an accident of the implementation, but were undocumented. The new
implementation of the resolver no longer supports these forms. A
possible replacement is replacing
the constraint with a requirement.. You can find discussion regarding
this at https://github.com/pypa/pip/issues/8210.
Fixes #12665
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12678: Changes --constraint flag into --requirement flag.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12678:
URL: https://github.com/apache/airflow/pull/12678#issuecomment-735078105
Unofrtunately, there is a difference. when you specify the file as --requirement it installs all of them. THinking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12678: Changes --constraint flag into --requirement flag.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12678:
URL: https://github.com/apache/airflow/pull/12678#issuecomment-735221614
Yeah. I am closing this PR. This --requirement will not work. I am not 100% sure if I understand what EXACTLY is being deprecated - whether it's the --constraint <URL> or whether it was caused by the "sphinx-theme" which was not versioned. I hope it 's the latter which means that this is not a problem at all and we can close the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12678: Changes --constraint flag into --requirement flag.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12678:
URL: https://github.com/apache/airflow/pull/12678#issuecomment-735116199
[The Workflow run](https://github.com/apache/airflow/actions/runs/388398950) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #12678: Changes --constraint flag into --requirement flag.
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #12678:
URL: https://github.com/apache/airflow/pull/12678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12678: Changes --constraint flag into --requirement flag.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12678:
URL: https://github.com/apache/airflow/pull/12678#issuecomment-735215742
What? You are going to need to provide more info here.
Those files _are_ constraint files. "If I'm installing module X, use this version".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org