You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Damien Lecan (JIRA)" <ji...@codehaus.org> on 2006/11/07 18:02:31 UTC
[jira] Created: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Support aggregated reports in a multi-modules project
-----------------------------------------------------
Key: MCHECKSTYLE-62
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-62
Project: Maven 2.x Checkstyle Plugin
Issue Type: New Feature
Reporter: Damien Lecan
It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MCHECKSTYLE-62:
------------------------------------
Fix Version/s: 2.8
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Assignee: Olivier Lamy
> Fix For: 2.8
>
> Attachments: checkstyle-aggregate.diff, checkstyle-aggregate-with-test.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280181#comment-280181 ]
Antonio Petrelli commented on MCHECKSTYLE-62:
---------------------------------------------
Thanks Herve,
Ok I'll refactor it following this guideline (in fact it should be even easier, less "if's").
In fact I copied from Maven PMD plugin, probably I chose an old-styled plugin then.
BTW, is there a checkstyle file that I can use?
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280511#comment-280511 ]
Antonio Petrelli commented on MCHECKSTYLE-62:
---------------------------------------------
Can you please put the "Fix for" value? I suppose it is 2.8.
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Assignee: Olivier Lamy
> Attachments: checkstyle-aggregate.diff, checkstyle-aggregate-with-test.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "jieryn (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280166#comment-280166 ]
jieryn commented on MCHECKSTYLE-62:
-----------------------------------
This is a particularly hairy area in Maven reporting, in general. To not have any tests covering the function is a mistake..
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280175#comment-280175 ]
Herve Boutemy commented on MCHECKSTYLE-62:
------------------------------------------
Antonio,
this patch adds an aggregate attribute: the preferred pattern (used in javadoc and jxr for exemple) is to have a separate mojo for aggregate reports
please consider Maven coding conventions too: http://maven.apache.org/developers/conventions/code.html
thank you for this patch: that's good to see such work
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280247#comment-280247 ]
Antonio Petrelli commented on MCHECKSTYLE-62:
---------------------------------------------
I forgot to tell that I patched the Checkstyle configuration for Maven too: it erroneously did not allow "unknown" Javadoc tags (that, in fact, are well known for Maven devs).
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff, checkstyle-aggregate-with-test.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-62) Support aggregated
reports in a multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280073#comment-280073 ]
Antonio Petrelli edited comment on MCHECKSTYLE-62 at 9/28/11 3:49 AM:
----------------------------------------------------------------------
This is a fast implementation of the aggregate parameter. It was written in a hurry so no test. WDYT?
Anyway I tested it on a multi-module project with an EAR, a WAR, some JARs and it worked.
was (Author: apetrelli):
This is a fast implementation of the aggregate parameter. It was written in a hurry so no test. WDYT?
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280237#comment-280237 ]
Antonio Petrelli commented on MCHECKSTYLE-62:
---------------------------------------------
Herve I have not been clear. What you are referring to are formatters for IDEs.
Checkstyle configurations are Checkstyle-relative XMLs. For example in Tiles we use this:
http://svn.eu.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
But probably it's better to ask the mailing list for this.
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated MCHECKSTYLE-62:
----------------------------------------
Attachment: checkstyle-aggregate.diff
This is a fast implementation of the aggregate parameter. It was written in a hurry so no test. WDYT?
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280169#comment-280169 ]
Antonio Petrelli commented on MCHECKSTYLE-62:
---------------------------------------------
jieryn you are right, but at least I volunteered to do something not done in 5 years.
Anyway give me some more time and I'll add tests.
Notice, however, that old tests work.
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated MCHECKSTYLE-62:
----------------------------------------
Attachment: checkstyle-aggregate-with-test.diff
Added patch creating two different reports, checkstyle and checkstyle-aggregate, with a simple test for the latter.
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff, checkstyle-aggregate-with-test.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MCHECKSTYLE-62.
-----------------------------------
Resolution: Fixed
fixed r1178094 . it test added r1178096
Thanks!
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Assignee: Olivier Lamy
> Attachments: checkstyle-aggregate.diff, checkstyle-aggregate-with-test.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-62) Support aggregated reports in a
multi-modules project
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280198#comment-280198 ]
Herve Boutemy commented on MCHECKSTYLE-62:
------------------------------------------
yes, checkstyle files are available for Eclipse and IDEA from the Maven coding conventions page
> Support aggregated reports in a multi-modules project
> -----------------------------------------------------
>
> Key: MCHECKSTYLE-62
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-62
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Reporter: Damien Lecan
> Attachments: checkstyle-aggregate.diff
>
>
> It would be nice if checkstyle plugin could build just one report in a multi-modules project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira