You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lei Xu <le...@cloudera.com> on 2017/04/27 00:32:15 UTC
Review Request 58773: SENTRY-1727. HMSPathsDumper.cloneToEntry should
set authzObjToEntries properly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58773/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1727
https://issues.apache.org/jira/browse/SENTRY-1727
Repository: sentry
Description
-------
It is discovered during the process of SENTRY-1713 that HMSPathsDumper.initializeFromDump is trying to clone a new HMSPaths from TPathsDump. Internally it calls cloneToEntry to construct HMSPaths.authzObjToEntries, which is representation of hive authorized objects to path entries mapping. It appears to be cloneToEntry fail to properly construct authzObjToEntries.
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java 7e569526feb56dffee142e3a0b106d216afde4e3
Diff: https://reviews.apache.org/r/58773/diff/1/
Testing
-------
mvn test -Dtest=TesetHDFSIntegrationEnd2End
Thanks,
Lei Xu
Re: Review Request 58773: SENTRY-1727. HMSPathsDumper.cloneToEntry
should set authzObjToEntries properly.
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58773/#review173141
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On April 27, 2017, 12:32 a.m., Lei Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58773/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 12:32 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1727
> https://issues.apache.org/jira/browse/SENTRY-1727
>
>
> Repository: sentry
>
>
> Description
> -------
>
> It is discovered during the process of SENTRY-1713 that HMSPathsDumper.initializeFromDump is trying to clone a new HMSPaths from TPathsDump. Internally it calls cloneToEntry to construct HMSPaths.authzObjToEntries, which is representation of hive authorized objects to path entries mapping. It appears to be cloneToEntry fail to properly construct authzObjToEntries.
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java 7e569526feb56dffee142e3a0b106d216afde4e3
>
>
> Diff: https://reviews.apache.org/r/58773/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest=TesetHDFSIntegrationEnd2End
>
>
> Thanks,
>
> Lei Xu
>
>