You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 14:25:47 UTC

[GitHub] [airflow] subkanthi commented on a change in pull request #17284: Add support of `path` parameter for GCloud Storage Transfer Service operators

subkanthi commented on a change in pull request #17284:
URL: https://github.com/apache/airflow/pull/17284#discussion_r678353286



##########
File path: airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py
##########
@@ -1026,6 +1048,16 @@ def __init__(
         self.delete_job_after_completion = delete_job_after_completion
         self._validate_inputs()
 
+        if self.destination_path and not self.destination_path.endswith('/'):

Review comment:
       This check seems to be the same as the gcs_path(if Im not wrong), does it make sense to move it to a function?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org