You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "sean.mullan (Jira)" <ji...@apache.org> on 2020/01/30 18:48:00 UTC
[jira] [Commented] (SANTUARIO-510) Support RSASSA-PSS with
Parameters
[ https://issues.apache.org/jira/browse/SANTUARIO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026919#comment-17026919 ]
sean.mullan commented on SANTUARIO-510:
---------------------------------------
I did a cursory (but not exhaustive) review and it looks ok to me. Two main comments:
# I did not see any changes for marshalling/unmarshalling the params in org/apache/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java so I don't think this is going to work if you are using the Java SE API (JSR 105). Perhaps this can be done later, but I would advise trying to do it with this patch so it is more complete.
# Did you test your changes with the RSASSA-PSS support that has been added to JDK 11?
> Support RSASSA-PSS with Parameters
> ----------------------------------
>
> Key: SANTUARIO-510
> URL: https://issues.apache.org/jira/browse/SANTUARIO-510
> Project: Santuario
> Issue Type: New Feature
> Reporter: Kunnar Klauks
> Assignee: Colm O hEigeartaigh
> Priority: Major
> Fix For: Java 2.2.0
>
> Attachments: updated-rsa-pss-trunk.patch, xmlsec_2_0_1_RSAPSSParams_support.patch, xmlsec_trunk_RSAPSSParams_support.patch
>
>
> Support for 'RSASSA-PSS with Parameters' as described in [https://tools.ietf.org/html/rfc6931#section-2.3.9]
>
> Mailing list topic [http://apache-xml-project.6118.n7.nabble.com/PATCH-RSASSA-PSS-with-Parameters-td45824.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)