You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 12:07:32 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2343: serial: Prevent RX stall

acassis commented on a change in pull request #2343:
URL: https://github.com/apache/incubator-nuttx/pull/2343#discussion_r527175361



##########
File path: drivers/serial/serial.c
##########
@@ -924,6 +924,20 @@ static ssize_t uart_read(FAR struct file *filep, FAR char *buffer, size_t buflen
               /* Re-enable UART Rx interrupts */
 
               uart_enablerxint(dev);
+
+              /* Check again if the RX buffer is empty.  The UART driver

Review comment:
       Hi @xiaoxiang781216, maybe if @tidklaas modify the comment to include that explanation will be enough!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org