You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2025/01/24 02:10:12 UTC
[PR] Metric: Add pipe linked tsfile size and count metric [iotdb]
Pengzna opened a new pull request, #14768:
URL: https://github.com/apache/iotdb/pull/14768
as title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Metric: Add pipe linked tsfile size and count metric [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #14768:
URL: https://github.com/apache/iotdb/pull/14768#discussion_r1948524073
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/enums/Metric.java:
##########
@@ -159,6 +159,7 @@ public enum Metric {
PIPE_PINNED_MEMTABLE_COUNT("pipe_pinned_memtable_count"),
PIPE_LINKED_TSFILE_COUNT("pipe_linked_tsfile_count"),
PIPE_PHANTOM_REFERENCE_COUNT("pipe_phantom_reference_count"),
+ PIPE_LINKED_TSFILE_SIZE("pipe_linked_tsfile_size"),
Review Comment:
Better put this below “pipe_linked_tsfile_count”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Metric: Add pipe linked tsfile size and count metric [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #14768:
URL: https://github.com/apache/iotdb/pull/14768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Metric: Add pipe linked tsfile size and count metric [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on code in PR #14768:
URL: https://github.com/apache/iotdb/pull/14768#discussion_r1950292009
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/enums/Metric.java:
##########
@@ -159,6 +159,7 @@ public enum Metric {
PIPE_PINNED_MEMTABLE_COUNT("pipe_pinned_memtable_count"),
PIPE_LINKED_TSFILE_COUNT("pipe_linked_tsfile_count"),
PIPE_PHANTOM_REFERENCE_COUNT("pipe_phantom_reference_count"),
+ PIPE_LINKED_TSFILE_SIZE("pipe_linked_tsfile_size"),
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org