You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/07/03 19:46:32 UTC
Review Request 67819: ATLAS-2775: Enhance basic search to search
entities with any classifications or no classifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67819/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2775
https://issues.apache.org/jira/browse/ATLAS-2775
Repository: atlas
Description
-------
Enhance basic search to search on entities with any classifications or no classifications
Basic search can now take the following value for classification:
_CLASSIFIED - Search on all entities with ANY classification associated (directly or through propagation)
_NOT_CLASSIFIED - Search on all entities with NO classifications associated (directly or through propagation)
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 588ad3e06
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java abe859f4f
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 2c84369dc
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 1f4007601
Diff: https://reviews.apache.org/r/67819/diff/1/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/500/console
Manually tested through POSTMAN client that basic search can now work with _CLASSIFIED and _NOT_CLASSIFIED values for classification.
Thanks,
Sarath Subramanian
Re: Review Request 67819: ATLAS-2775: Enhance basic search to search
entities with any classifications or no classifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67819/#review205694
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 3, 2018, 9:45 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67819/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 9:45 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2775
> https://issues.apache.org/jira/browse/ATLAS-2775
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhance basic search to search on entities with any classifications or no classifications
>
> Basic search can now take the following value for classification:
>
> _CLASSIFIED - Search on all entities with ANY classification associated (directly or through propagation)
> _NOT_CLASSIFIED - Search on all entities with NO classifications associated (directly or through propagation)
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 39ebf23c5
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 588ad3e06
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java abe859f4f
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 2c84369dc
> repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 1f4007601
>
>
> Diff: https://reviews.apache.org/r/67819/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/500/console
>
> Manually tested through POSTMAN client that basic search can now work with _CLASSIFIED and _NOT_CLASSIFIED values for classification.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67819: ATLAS-2775: Enhance basic search to search
entities with any classifications or no classifications
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67819/
-----------------------------------------------------------
(Updated July 3, 2018, 2:45 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Moved hardcoded values to a REST visible class.
Bugs: ATLAS-2775
https://issues.apache.org/jira/browse/ATLAS-2775
Repository: atlas
Description
-------
Enhance basic search to search on entities with any classifications or no classifications
Basic search can now take the following value for classification:
_CLASSIFIED - Search on all entities with ANY classification associated (directly or through propagation)
_NOT_CLASSIFIED - Search on all entities with NO classifications associated (directly or through propagation)
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 39ebf23c5
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 588ad3e06
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java abe859f4f
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 2c84369dc
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 1f4007601
Diff: https://reviews.apache.org/r/67819/diff/2/
Changes: https://reviews.apache.org/r/67819/diff/1-2/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/500/console
Manually tested through POSTMAN client that basic search can now work with _CLASSIFIED and _NOT_CLASSIFIED values for classification.
Thanks,
Sarath Subramanian
Re: Review Request 67819: ATLAS-2775: Enhance basic search to search
entities with any classifications or no classifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67819/#review205693
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 65 (patched)
<https://reviews.apache.org/r/67819/#comment288586>
Consider replacing hardcoded values, _CLASSIFIED & _NOT_CLASSIFIED, with a constant defined in a REST visible class - like SearchParameters. UI can populate drop-down with these values.
- Madhan Neethiraj
On July 3, 2018, 7:46 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67819/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 7:46 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2775
> https://issues.apache.org/jira/browse/ATLAS-2775
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhance basic search to search on entities with any classifications or no classifications
>
> Basic search can now take the following value for classification:
>
> _CLASSIFIED - Search on all entities with ANY classification associated (directly or through propagation)
> _NOT_CLASSIFIED - Search on all entities with NO classifications associated (directly or through propagation)
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 588ad3e06
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java abe859f4f
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 2c84369dc
> repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 1f4007601
>
>
> Diff: https://reviews.apache.org/r/67819/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/500/console
>
> Manually tested through POSTMAN client that basic search can now work with _CLASSIFIED and _NOT_CLASSIFIED values for classification.
>
>
> Thanks,
>
> Sarath Subramanian
>
>