xsp logicsheets are broken in the latest c2 cvs

[Donald Ball <ba...@webslingerZ.com>]

hey guys. i've got an xsp page like so:

<xsp:page
  xmlns:xsp="http://apache.org/xsp"
  xmlns:esql="http://apache.org/cocoon/SQL/v2"
  xmlns:xsp-request="http://apache.org/xsp/request"
  language="java"
>

<page>
  <esql:connection>
    <esql:pool>intranet</esql:pool>
    <esql:execute-query>
      <esql:query>select
client_table.id,client_table.name,client_status_table.name from
client_table,client_status_table where client_status_id =
client_status_table.id and client_id =
<esql:parameter><xsp-request:get-parameter
name="id"/></esql:parameter></esql:query>

this is just about as vanilla as it gets. it fails to compile, warning:

WARN    10793   [cocoon  ] (tcpConnection-6802-1): Sitemap Error Process
org.apache.cocoon.ProcessingException: Language
Exception:org.apache.cocoon.components.language.LanguageException: Error
compiling client_xsp:
Line 305, column 71:  ')' expected.

the source it fails to compile is:

_esql_query.prepared_statement.setString(1, String.valueOf(""
  + xspAttr.addAttribute("", "name", "name", "CDATA", "id");
this.contentHandler.startElement("http://apache.org/xsp/request",
"get-parameter", "xsp-request:get-parameter", xspAttr);

so instead of trying to resolve the call to get-parameter, the xsp engine
is creating a get-parameter element on the output sax stream. hm.

maybe the xsp-request logicsheet isn't being applied as it ought:

DEBUG   68470   [cocoon  ] (tcpConnection-6802-0): Making URL from
jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/esql.xsl
DEBUG   68470   [cocoon  ] (tcpConnection-6802-0): Logicsheet
Used:jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/esql.xsl
DEBUG   68471   [cocoon  ] (tcpConnection-6802-0): Making URL from
jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/request.xsl
DEBUG   68471   [cocoon  ] (tcpConnection-6802-0): Logicsheet
Used:jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/request.xsl
DEBUG   68471   [cocoon  ] (tcpConnection-6802-0): Making URL from
jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/xsp.xsl
DEBUG   68471   [cocoon  ] (tcpConnection-6802-0): Logicsheet
Used:jar:file:/usr/local/resin/virtual/intranet.webslingerZ.com/webapps/database/WEB-INF/lib/cocoon.jar!/org/apache/cocoon/components/language/markup/xsp/java/xsp.xsl

but no, it's certainly listed there. maybe some change has affected the
get-nested-content function used by esql to resolve the nodes underneath
esql:parameter - well, no, it can't be that since i tried moving
xsp-request:get-parameter to somewhere else and it didn't work there
either, same basic problem.

only other thing i can think is that maybe esql isn't copying its input
nodes as it ought, screwing them up somehow, but no, it's got this rule:

<xsl:template match="@*|node()" priority="-1">
  <xsl:copy>
    <xsl:apply-templates select="@*|node()"/>
  </xsl:copy>
</xsl:template>

which is correct.

i honestly couldn't tell you when this stuff broke because i haven't used
xsp in a while and i'm beginning to remember why i abandoned it in the
first place. i'm switching gears back to the InspectionTransformer, but
this bug should really be resolved before 2.1 is released. it should be
easy to duplicate, let me know if i should check in an example tho.

- donald


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org