You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/02/17 21:46:15 UTC
Review Request 43641: Removed unnecessary parameter from validation
function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/
-----------------------------------------------------------
Review request for mesos, Michael Park and Neil Conway.
Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940
Repository: mesos
Description
-------
Removed unnecessary parameter from validation function.
Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter to the Unreserve operation validation function is no longer necessary.
Diffs
-----
src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd
src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22
src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c
src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
Diff: https://reviews.apache.org/r/43641/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 43641: Removed unnecessary parameter from
validation function.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120232
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:43 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary parameter from validation function.
>
> Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter to the Unreserve operation validation function is no longer necessary.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
> src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547
> src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c
> src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
>
> Diff: https://reviews.apache.org/r/43641/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43641: Removed unnecessary parameter from
validation function.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120213
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:43 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary parameter from validation function.
>
> Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter to the Unreserve operation validation function is no longer necessary.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
> src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547
> src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c
> src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
>
> Diff: https://reviews.apache.org/r/43641/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43641: Removed unnecessary parameter from
validation function.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120210
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Feb. 22, 2016, 6:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43641/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:43 p.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary parameter from validation function.
>
> Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter to the Unreserve operation validation function is no longer necessary.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
> src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547
> src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c
> src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
>
> Diff: https://reviews.apache.org/r/43641/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 43641: Removed unnecessary parameter from
validation function.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 6:43 p.m.)
Review request for mesos, Michael Park and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940
Repository: mesos
Description
-------
Removed unnecessary parameter from validation function.
Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter to the Unreserve operation validation function is no longer necessary.
Diffs (updated)
-----
src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547
src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c
src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
Diff: https://reviews.apache.org/r/43641/diff/
Testing
-------
`make check`
Thanks,
Greg Mann