You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2020/12/01 01:24:00 UTC
[jira] [Commented] (BEAM-9187)
org.apache.beam.runners.fnexecution.control.DefaultJobBundleFactoryTest.loadBalancesBundles
is flaky
[ https://issues.apache.org/jira/browse/BEAM-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241177#comment-17241177 ]
Brian Hulette commented on BEAM-9187:
-------------------------------------
I'm able to reproduce this pretty reliably on an n1-standard-1 GCP VM (I happened to be testing on one for a completely different purpose). I have to run the full {{:runners:java-fn-execution:test}} task for it to happen. I haven't seen it fail when running loadBalancesBundles alone.
It seems that, in the error case, what's happening is as soon as the forked thread releases the semaphore [here|https://github.com/apache/beam/blob/5e9237cd425da92a98536ba598a6217c21b31286/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java#L560], the main thread continues, [creating the bundle|https://github.com/apache/beam/blob/5e9237cd425da92a98536ba598a6217c21b31286/runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactoryTest.java#L478], and then making the assertions. However since we left the forked thread, it never got out of the b2.close() call and [set the boolean|https://github.com/apache/beam/blob/5e9237cd425da92a98536ba598a6217c21b31286/runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactoryTest.java#L470].
> org.apache.beam.runners.fnexecution.control.DefaultJobBundleFactoryTest.loadBalancesBundles is flaky
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-9187
> URL: https://issues.apache.org/jira/browse/BEAM-9187
> Project: Beam
> Issue Type: Test
> Components: runner-core
> Reporter: Etienne Chauchot
> Priority: P1
> Labels: flake, flaky-test
>
> [org.apache.beam.runners.fnexecution.control.DefaultJobBundleFactoryTest.loadBalancesBundles|https://builds.apache.org/job/beam_PreCommit_Java_Commit/9730/testReport/junit/org.apache.beam.runners.fnexecution.control/DefaultJobBundleFactoryTest/loadBalancesBundles/] UTest seem to be flaky:
> [https://builds.apache.org/job/beam_PreCommit_Java_Commit/9730/testReport/junit/org.apache.beam.runners.fnexecution.control/DefaultJobBundleFactoryTest/loadBalancesBundles/]
>
> I have runner-core as tag but in reality this test is in org.apache.beam.runners.fnexecution.control but there is no corresponding tag
--
This message was sent by Atlassian Jira
(v8.3.4#803005)