You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by beradrian <gi...@git.apache.org> on 2015/05/07 10:37:56 UTC

[GitHub] commons-lang pull request: Fix issue 1122

GitHub user beradrian opened a pull request:

    https://github.com/apache/commons-lang/pull/86

    Fix issue 1122

    Fixes issue https://issues.apache.org/jira/browse/LANG-1122 as discussed.
    I also added a link to an article on my blog about shift algorithm, as it was discussed previously. Hope it's fine, if not, I can remove it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/beradrian/commons-lang master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit 5b7608d1549989d92dd159392c19d9ba8ce0e62e
Author: beradrian <be...@yahoo.com>
Date:   2015-05-07T06:50:41Z

    consistent treatment for negative indices for swap method

commit e79a590e0cdabd93883aca964db2a862ff3f8490
Author: beradrian <be...@yahoo.com>
Date:   2015-05-07T08:31:28Z

    new test case
    explanations about algorithm

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Fix issue 1122

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/86


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Fix issue 1122

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:

    https://github.com/apache/commons-lang/pull/86#issuecomment-99776317
  
    
    [![Coverage Status](https://coveralls.io/builds/2507382/badge)](https://coveralls.io/builds/2507382)
    
    Coverage decreased (-0.09%) to 93.27% when pulling **e79a590e0cdabd93883aca964db2a862ff3f8490 on beradrian:master** into **d6dd2b4cd4a337c5517952680c3714e5d08e9cb8 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---